Update cleave.js to cleave-zen
#2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmandoGraterol
force-pushed
the
maintenance/2001-update-cleave-js
branch
from
455908f
to
c840521
Compare
rdig
requested changes
Mar 7, 2024
|
chmanie
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
This looks good code wise and functionality wise!
I was wondering whether we can do something about the cursor jumping when changing digits in the middle of the number. I know this was a problem before, I just thought it might be fixed by updating this library...
ArmandoGraterol
force-pushed
the
maintenance/2001-update-cleave-js
branch
from
c840521
to
aa11b71
Compare
|
@rdig It might be what Chris mentions but I've rebased it just in case |
rdig
reviewed
Mar 10, 2024
rdig
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this took longer than anticipated.
The author deprecated cleave.js: nosir/cleave.js#723 and a new library has been created in its place: https://github.com/nosir/cleave-zen
The approach to how the library works changed almost completely, so I had to make some extra modifications to the forms (also to simplify the code as it was hard to understand what the heck was happening). I think the new library is easier to use and integrate.
Hopefully, everything still works as expected but now without the annoying warning of
componentWillReceiveProps. The forms most affected by the changes are mint tokens, transfer funds, and simple payments.Resolves #2001