Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed direct-send RPC-API to accept list of UTXOs #1713

Closed

Conversation

amitx13
Copy link

@amitx13 amitx13 commented Jun 9, 2024

This PR fixes #1712 and addresses joinmarket-webui/jam#772
Changes Made:

  1. Updated the direct-send API to accept a list of UTXOs specified by the user.
  2. Implemented backend logic to handle the selection of these UTXOs for the transaction.
  3. Added necessary validation checks to ensure the specified UTXOs are part of the user's wallet and are unfrozen.

src/jmclient/wallet_rpc.py Outdated Show resolved Hide resolved
src/jmclient/taker_utils.py Outdated Show resolved Hide resolved
@amitx13
Copy link
Author

amitx13 commented Jun 9, 2024

Thank you for the feedback. I will ensure the RPC-API maintains backwards compatibility and update the documentation as well.

@amitx13
Copy link
Author

amitx13 commented Jun 11, 2024

Hey @kristapsk I am done with the requested changes. Could you please take a look when you have a moment 🙏

@amitx13 amitx13 requested a review from kristapsk June 11, 2024 10:56
@amitx13
Copy link
Author

amitx13 commented Jun 16, 2024

Hey @kristapsk if you have a moment, could you please take a look at docs/api/wallet-rpc.yaml I tried everything from my side but still, OpenAPI Diff keeps failing. It will be a great help for me as well as for JAM and JoinMarket users

@kristapsk
Copy link
Member

Hey @kristapsk if you have a moment, could you please take a look at docs/api/wallet-rpc.yaml I tried everything from my side but still, OpenAPI Diff keeps failing. It will be a great help for me as well as for JAM and JoinMarket users

I'm quite busy with other stuff currently, but will try to take a look at some point, if you will not be able to solve that yourself.

@amitx13
Copy link
Author

amitx13 commented Jul 15, 2024

Hey @kristapsk if you have a moment could you please re-run the workflows.

@amitx13
Copy link
Author

amitx13 commented Jul 19, 2024

Hey, I don't know if I am correct, but I think creating a new PR from a new branch to fix this OpenAPI Diff issue.This way, the OpenAPI Diff action will not detect a breaking change since, in the history of that branch, selected_utxos was never required. New PR to address this issue: #1721

@amitx13 amitx13 closed this Jul 19, 2024
@kristapsk
Copy link
Member

Hey, I don't know if I am correct, but I think creating a new PR from a new branch to fix this OpenAPI Diff issue.This way, the OpenAPI Diff action will not detect a breaking change since, in the history of that branch, selected_utxos was never required. New PR to address this issue: #1721

If it solves it, then there's bug in OpenAPI Diff action. Intent is for it to compare against master branch. But you could try!

@amitx13
Copy link
Author

amitx13 commented Jul 20, 2024

Hey, I don't know if I am correct, but I think creating a new PR from a new branch to fix this OpenAPI Diff issue.This way, the OpenAPI Diff action will not detect a breaking change since, in the history of that branch, selected_utxos was never required. New PR to address this issue: #1721

If it solves it, then there's bug in OpenAPI Diff action. Intent is for it to compare against master branch. But you could try!

Oh, okay. Then why is the OpenAPI Diff action always showing breaking changes? I introduced a parameter, marked it as optional, and updated the wallet-rpc.yaml just like you did with txfee and tumbler_options.

@roshii
Copy link
Contributor

roshii commented Aug 30, 2024

I did not meant to approve, it went wrong somehow... My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants