This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
35 add ci #45
Merged
35 add ci #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jwbot
reviewed
Aug 19, 2018
| @@ -52,8 +52,7 @@ class HoursView @JvmOverloads constructor( | |||
| hourHeightMin = getDimension(R.styleable.HoursView_hourHeightMin, 0f) | |||
| hourHeightMax = getDimension(R.styleable.HoursView_hourHeightMax, 0f) | |||
| hourSize = getDimensionPixelSize(R.styleable.HoursView_hourSize, 16) | |||
There was a problem hiding this comment.
| This expression contains a magic number. Consider defining it to a well named constant. |
jwbot
reviewed
Aug 19, 2018
| throw IllegalStateException("datePaint is null") | ||
|
|
||
| val text = weekDayStrings[cal.get(Calendar.DAY_OF_WEEK)] | ||
| ?: throw IllegalStateException("weekDayString for day ${cal.get(Calendar.DAY_OF_WEEK)} not found") | ||
| val textLeft = left + width * day / 7 + .3f * dateSize |
There was a problem hiding this comment.
| This expression contains a magic number. Consider defining it to a well named constant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35
Description
Travis is integrated as CI. Danger with detekt and Android Lint perform automated linting.
Checklist