Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2d position_to_transform changing child Transform z-component #134

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix 2d position_to_transform changing child Transform z-component #134

merged 2 commits into from
Aug 29, 2023

Conversation

ShaddowSpy
Copy link
Contributor

Fixes #125
child's Transform.translation.z was previously added twice, in extend() and reparented_to()
This change removes the addition that was in extend().

@Jondolf Jondolf added the bugfix label Aug 29, 2023
@Jondolf
Copy link
Owner

Jondolf commented Aug 29, 2023

Thanks!

@Jondolf Jondolf merged commit da89cb8 into Jondolf:main Aug 29, 2023
3 checks passed
@Jondolf Jondolf added C-Bug Something isn't working 2D Specific to two dimensions and removed bugfix labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2D Specific to two dimensions C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2D child Z grows without bounds
2 participants
@ShaddowSpy @Jondolf