Collision post processing #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Enhancement
|
#156 is now merged! It exposes |
A simplistic example of implementing one-way platforms via collision filtering as part of the narrow-phase collision post-processing step.
datael
force-pushed
the
collision_post_processing
branch
from
ba6d7ee
to
429bdfd
Compare
datael
force-pushed
the
collision_post_processing
branch
from
429bdfd
to
4ce56b4
Compare
|
Ok, that sample is now updated to use normal2 where appropriate. |
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
Jondolf
reviewed
Sep 24, 2023
There was a problem hiding this comment.
I left quite a few comments, mostly just additional code comments or tweaks to language/naming and some of the values in the example.
The one-way platform example is excellent, and the system could probably be just dropped into most projects with very little changes. I'm happy to merge this once we've sorted out the things I mentioned in my review :)
Co-authored-by: Joona Aalto <[email protected]>
…2d example (#150) This appears to bring them to a height such that the vertical distance between the ground and the top edge of the lowest platform is the same distance between the top edge of the lowest platform and the next. Co-authored-by: Joona Aalto <[email protected]>
#150) Co-authored-by: Joona Aalto <[email protected]>
Co-authored-by: Joona Aalto <[email protected]>
datael
commented
Sep 25, 2023
Co-authored-by: Joona Aalto <[email protected]>
Change "edit" to "modify" to match the paragraph above.
RJ
pushed a commit
to RJ/avian
that referenced
this pull request
Sep 25, 2023
# Objective Create a stage to allow filtering and changing collisions from user-defined systems. This is the simplest part of Jondolf#150: the Global Physics hooks via user systems only. ## Solution - Adds `SubstepSet::PostProcessCollisions`, which is directly after `SubstepSet::NarrowPhase` - Adds `PostProcessCollisions` schedule, which is run in `SubstepSet::PostProcessCollisions` - Exposes `retain` from `Collisions` to allow direct modification of the set of collisions Also includes a simple one-way-platform example. --------- Co-authored-by: Joona Aalto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Create a stage to allow filtering and changing collisions from user-defined systems.
This is the simplest part of #150: the Global Physics hooks via user systems only.
Solution
SubstepSet::PostProcessCollisions, which is directly afterSubstepSet::NarrowPhasePostProcessCollisionsSchedule, which is run inSubstepSet::PostProcessCollisionsretainfromCollisionsto allow direct modification of the set of collisionsAlso includes a simple one-way-platform example.