-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collision post processing #155
Conversation
#156 is now merged! It exposes |
A simplistic example of implementing one-way platforms via collision filtering as part of the narrow-phase collision post-processing step.
ba6d7ee
to
429bdfd
Compare
429bdfd
to
4ce56b4
Compare
Ok, that sample is now updated to use normal2 where appropriate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left quite a few comments, mostly just additional code comments or tweaks to language/naming and some of the values in the example.
The one-way platform example is excellent, and the system could probably be just dropped into most projects with very little changes. I'm happy to merge this once we've sorted out the things I mentioned in my review :)
Co-authored-by: Joona Aalto <[email protected]>
…2d example (#150) This appears to bring them to a height such that the vertical distance between the ground and the top edge of the lowest platform is the same distance between the top edge of the lowest platform and the next. Co-authored-by: Joona Aalto <[email protected]>
#150) Co-authored-by: Joona Aalto <[email protected]>
Co-authored-by: Joona Aalto <[email protected]>
Co-authored-by: Joona Aalto <[email protected]>
Change "edit" to "modify" to match the paragraph above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
# Objective Create a stage to allow filtering and changing collisions from user-defined systems. This is the simplest part of Jondolf#150: the Global Physics hooks via user systems only. ## Solution - Adds `SubstepSet::PostProcessCollisions`, which is directly after `SubstepSet::NarrowPhase` - Adds `PostProcessCollisions` schedule, which is run in `SubstepSet::PostProcessCollisions` - Exposes `retain` from `Collisions` to allow direct modification of the set of collisions Also includes a simple one-way-platform example. --------- Co-authored-by: Joona Aalto <[email protected]>
Objective
Create a stage to allow filtering and changing collisions from user-defined systems.
This is the simplest part of #150: the Global Physics hooks via user systems only.
Solution
SubstepSet::PostProcessCollisions
, which is directly afterSubstepSet::NarrowPhase
PostProcessCollisionsSchedule
, which is run inSubstepSet::PostProcessCollisions
retain
fromCollisions
to allow direct modification of the set of collisionsAlso includes a simple one-way-platform example.