Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PreparePlugin configurable #292

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Jan 1, 2024

Objective

It's important to be able to disable transform->position and position->transform syncing in the PreparePlugin so that positions don't get messed up if using an alternative coordinate system, such as a floating origin. This PR makes PreparePlugin more configurable and exposes a more detailed PrepareSet to make external customization easier to manage.

Solution

Adds position_to_transform and transform_to_position fields to a new PrepareConfig, and exposes PrepareSet to the public so that you can add your own systems there without leaking too many implementation details.


Changelog

Added

  • Added PrepareConfig, based off of SyncConfig.

Changed

  • Split up PrepareSet into individual groups.
  • Refactored the system scheduling in PreparePlugin.
  • Made init_transforms respect PrepareConfig.

@Rigidity Rigidity marked this pull request as ready for review January 1, 2024 19:46
@Rigidity Rigidity marked this pull request as draft January 1, 2024 19:58
@Rigidity Rigidity marked this pull request as ready for review January 1, 2024 23:02
@Jondolf Jondolf added the C-Enhancement New feature or request label Jan 6, 2024
Copy link
Owner

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this finally; The new structure looks good, and I like the documentation a lot. This adds some useful flexibility and configurability. Thanks!

@Jondolf Jondolf merged commit b2408fb into Jondolf:main Jan 6, 2024
4 checks passed
@Rigidity Rigidity deleted the configurable-prepare branch January 8, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants