Adding Collider::round_cuboid #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Enhancement
kav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Looking through the code it appears we have a round cuboid available from Parry but are missing the function to create it. Rounded cuboids are handy for several things though in my case it's providing a smooth tunnel edge for couched players entering tunnels and also offering slight "just missed it" jump handling.
Solution
I reviewed the cubiod functions and SharedShapes to determine the round_cubiod pattern. Not sure if I've missed some things and happy to accept any changes or add tests and docs as needed.
Changelog
Added
2d:
Collider::round_cuboid(x_length: Scalar, y_length: Scalar, border_radius: Scalar)3d:
Collider::round_cuboid(x_length: Scalar, y_length: Scalar, z_length: Scalar, border_radius: Scalar)