Add back global contact positions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Contact` should have both the local and global contact positions, as users and e.g. the debug plugin often need global coordinates.
Jondolf
added
C-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84 changed contact positions to be local in order to improve numerical stability. However,
Contactshould also have the global contact positions, as users and e.g. the debug plugin often need global coordinates, and it's unnecessry to do extra component queries just to convert into global coordinates manually.This PR renames
point1andpoint2tolocal_point1andlocal_point2and adds back the originalpoint1andpoint2that were in global coordinates. This also fixes the debug plugin contact rendering, which was broken by #84.