Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”₯ remove test of make file #85

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

JoseRZapata
Copy link
Owner

@JoseRZapata JoseRZapata commented Jul 10, 2024

Remove unit test of makefile

✨ Context

THe unit test of the makefile has security issues based con bandit.

🧠 Rationale behind the change

This test is not necesary so i will remove it

Type of changes

  • πŸ› Bugfix (changes that fix a problem with the current behavior)
  • βœ… Tests (Unit tests, integration tests, end-to-end tests)

πŸ›  What does this PR implement

Remove test_cookiecutter_make_helpunit test

πŸ§ͺ How should this be tested?

  • poetry run pytest --cov
  • pre-commit run -a

Summary by Sourcery

This pull request removes a unit test (test_cookiecutter_make_help) from the test suite due to identified security issues. The test was deemed unnecessary and has been deleted to improve security.

  • Bug Fixes:
    • Removed a unit test that had security issues as identified by Bandit.
  • Tests:
    • Deleted the test_cookiecutter_make_help unit test from the test suite.

Copy link

sourcery-ai bot commented Jul 10, 2024

Reviewer's Guide by Sourcery

This pull request removes the test_cookiecutter_make_help unit test from the tests/test_create_template.py file. The rationale behind this change is to address security concerns flagged by Bandit. The test was deemed unnecessary and thus removed. The changes include deleting the import of the subprocess module and the entire test function.

File-Level Changes

Files Changes
tests/test_create_template.py Removed the unit test for the makefile due to security issues identified by Bandit.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoseRZapata - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟒 General issues: all looks good
  • 🟒 Security: all looks good
  • 🟒 Testing: all looks good
  • 🟒 Complexity: all looks good
  • 🟒 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment to tell me if it was helpful.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 100.00%. Comparing base (4478603) to head (f5a6142).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           62        57    -5     
=========================================
- Hits            62        57    -5     

@JoseRZapata JoseRZapata merged commit 8d6e592 into main Jul 10, 2024
7 checks passed
@JoseRZapata JoseRZapata deleted the feature/remove_make_test branch July 10, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant