-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Bounty no.17 - Discord Video Bot #196
Conversation
Mine "Developer mode" was in User Settings -> Advanced -> Developer Mode. Got this error after uploading this video (https://play.joystream.org/video/520): Note: |
By commenting the |
oh seems to be because my channel doesn't have an avatar :) |
Your channel has no avatar, this was the root cause of an issue. I'll try to fix this today |
I think that is a bit important to clear the |
Agreed |
LGTM! 👍 |
this was approved by the council in the following proposal: https://testnet.joystream.org/#/proposals/154 |
@bwhm as this involves code I won't merge it and will wait for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @singulart!
Was about to test deploy it now, but I get:
this integration is private. only the application owner can add it.
I assume this means only the bot owner, not the server owner?
Yes, the bot is an application refered to in this message I think |
Thanks for the quick reply. Are you able to grant us the permission required? |
You don't need any specific permission from me) My assumption was that Jsgenesis would create the bot in discord guided by the instructions in the community repo: https://github.com/Joystream/community-repo/tree/master/community-contributions/discordbot |
Sorry for the confusion, I thought it was already deployed as I got a link for it earlier :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well, but I'm seeing some issues:
Deployment issues
Running failed due to replaceAll
I had to manually add it with
yarn add string.prototype.replaceall
Then, the build failed before I created a new file:
node_modules/string.prototype.replaceall/index.d.ts
with
declare module 'string.prototype.replaceall';
Errors
I'm getting this error all the time:
Video 1853 already announced.
TypeError: Cannot read property 'metadata' of null
at /home/joystream/singulart-community-repo/community-contributions/joystreamvideobot/lib/src/bot.js:55:85
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async main (/home/joystream/singulart-community-repo/community-contributions/joystreamvideobot/lib/src/bot.js:33:9)
It doesn't crash, but I don't think it's great to have it running like that.
These are rather small issues in the grand scheme of things, but would be great if you could fix them :)
Deployment issue mentioned can be fixed by upgrading the node version, I believe. I will look into the missing metadata |
Comments of @bwhm were addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the quick fixes!
The implementation of a bot that is expected to fulfil the requirements laid out here
Example of the bot announcement: https://imgur.com/a/MXPkC2z
Supported data points:
Tags are not supported, because this feature is not yet implemented in Joystream Studio.