This repository has been archived by the owner on Oct 21, 2021. It is now read-only.
Modify to_dot #206
Open
Modify to_dot #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to_dot shout also allow for preamble blocks as in currently only isolated attributes=value pairs are allowed. |
|
I understood. |
dehann
reviewed
Dec 8, 2017
| @@ -30,7 +30,7 @@ function to_dot{G<:AbstractGraph}(graph::G, stream::IO,attrs::AttributeDict=Attr | |||
| write(stream,"$(vertex_index(vtx,graph))$attrs\n") | |||
| end | |||
| for edge in edges(graph) | |||
| write(stream,"$(vertex_index(source(edge), graph)) $(edge_op(graph)) $(vertex_index(target(edge), graph))\n") | |||
| write(stream,"$(vertex_index(source(edge), graph)) $(edge_op(graph)) $(vertex_index(target(edge), graph))$(has_edge_attrs ? string(" ", to_dot(attributes(edge, graph))) : "")\n") | |||
There was a problem hiding this comment.
Hi, I'm not sure we should be calling to_dot inside the string interpolation here. Could you maybe just explain a little more on why calling to_dot(attributes(edge, graph))) inside the string interpolation is the right thing to do? Sorry, but I am not the most knowledgeable on to_dot. Although, I would expect a lower level functio that unpacks the graph edge attributes into a string -- is to_dot really the best one?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating the amazing library.
I noticed that
to_dot()function did not print the edge attributes inGraphs.graph(ExVertex[], ExEdge{ExVertex}[], is_directed=false).I modified the corresponding line in
src/dot.jland added test codes totest/dot2.jl.Would you please review these changes?