Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raised dependencies #16

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

racinmat
Copy link
Contributor

@racinmat racinmat commented Oct 6, 2021

This allows people to use this repo with newer dependencies.
Everything should work as it does not seem to use functions or structures which are present in [email protected] but not in [email protected].
Fixes #15 .
Please, label this PR with hacktoberfest-accepted.
Thanks.

@logankilpatrick logankilpatrick merged commit cf0855f into JuliaLangSlack:main Oct 6, 2021
@logankilpatrick
Copy link
Member

Thanks for this. I would suggest checking out: FluxML/fluxml.github.io#107

@logankilpatrick
Copy link
Member

PR's to this repo will not be very impactful whereas PR's to Flux will actually help the community

@racinmat
Copy link
Contributor Author

racinmat commented Oct 6, 2021

Thanks, I'll take a look at this issue in Flux.jl.
This PR is impactful for me, because we're using Slack.jl in our company and we need all dependencies to go through the package server. So this actually helps us.

@logankilpatrick
Copy link
Member

😄 I never imaged people would actually use Slack.jl beyond the Julia Slack bots I had set up. Glad to hear you are using it and in that case, feel free to continue to add features!

@logankilpatrick
Copy link
Member

Might be cool to add a showcase section in the Readme and talk about where Slack.jl is being used, feel free to open that PR

@racinmat
Copy link
Contributor Author

racinmat commented Oct 6, 2021

We use it just to send some messages to our internal slack when some experiment errors, we basically call sendtoslack(data, some_our_url), but if it makes sense to mention in the Readme that we use this package at Avast in R&D during our experiments, I can definitely send PR.

Btw, I noticed there is yet another registered package for sending messages to slack https://github.com/Sumidu/slacker.jl which seems to be doing similar thing, but in a bit different manner. So it seems few more people have need to send things to slack from julia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old zlib dependency, which is not using proper artifact installation.
2 participants