Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CImGuiPack] Update to ImGui 1.90.8 #8870

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

JamesWrigley
Copy link
Contributor

Note that the URL changed in Gnimuc/CImGui.jl#119.

CC @Gnimuc

@Gnimuc
Copy link
Contributor

Gnimuc commented Jun 9, 2024

Thanks for following this up!

We could also pick up LLVM.jl's way to support a local-build: https://github.com/maleadt/LLVM.jl/blob/master/deps/build_local.jl

I think we should also move CImGui.jl to JuliaImGui if more people are get involved in.

@JamesWrigley
Copy link
Contributor Author

We could also pick up LLVM.jl's way to support a local-build: https://github.com/maleadt/LLVM.jl/blob/master/deps/build_local.jl

Hmm, yeah that could be useful 🤔

I think we should also move CImGui.jl to JuliaImGui if more people are get involved in.

Sure, that's fine with me 👍

@JamesWrigley JamesWrigley marked this pull request as draft June 9, 2024 15:10
@JamesWrigley
Copy link
Contributor Author

(made this a draft for now because I think some more build changes are necessary)

@JamesWrigley JamesWrigley marked this pull request as ready for review June 24, 2024 15:45
@JamesWrigley
Copy link
Contributor Author

I believe this is ready to merge now.

@JamesWrigley
Copy link
Contributor Author

We could also pick up LLVM.jl's way to support a local-build: https://github.com/maleadt/LLVM.jl/blob/master/deps/build_local.jl

We have something like that now :) https://github.com/Gnimuc/CImGui.jl/blob/1.90.8/cimgui-pack/build.jl

@giordano giordano merged commit 7e0cfd6 into JuliaPackaging:master Jun 26, 2024
23 checks passed
@JamesWrigley JamesWrigley deleted the cimguipack-update branch June 26, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants