Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shape function (duplicate of size) #298

Closed
JakobAsslaender opened this issue Dec 5, 2023 · 1 comment
Closed

Remove shape function (duplicate of size) #298

JakobAsslaender opened this issue Dec 5, 2023 · 1 comment

Comments

@JakobAsslaender
Copy link
Contributor

Hi everyone,

so sorry, I just realized that you prefer opening an issue instead of a PR (which I had already done #297). Anyways, here is the issue and I would be grateful for your feedback!

We have encountered in several of our packages a conflict between the functions LinearOperators.shape and Distributions.shape (JuliaImageRecon/LinearOperatorCollection.jl#3 (comment)). Since the former is a duplicate of size, I was wondering if it would be feasible to drop shape from this package. To make everyone's life easier, I put those changes in a PR (#297).

Many thanks for considering!
@dpo
Copy link
Member

dpo commented Dec 5, 2023

Sorry for the slow reply and thank you for the pull request. CI is running now.

@JakobAsslaender JakobAsslaender mentioned this issue Dec 5, 2023
Merged
@dpo dpo closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpo @JakobAsslaender