[breaking] Remove shape function (duplicate of size) #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Solves #298 |
|
The failed test is due to missing |
|
Oops, needs a version bump in Project.toml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
we have encountered in several of our packages a conflict between the functions
LinearOperators.shapeandDistributions.shape(JuliaImageRecon/LinearOperatorCollection.jl#3 (comment)). Since the former is a duplicate ofsize, I was wondering if it would be feasible to dropshapefrom this package. To make everyone's life easier, I put those changes in a PR.This change would be breaking as we would drop an exported function. But fixes in other packages should be straight forward with a search & replace.
Many thanks for considering!