Implement chainrules #279
Merged
Implement chainrules #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 97.43% 96.57% -0.86%
==========================================
Files 14 15 +1
Lines 1013 1052 +39
==========================================
+ Hits 987 1016 +29
- Misses 26 36 +10
☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements chainrules for the product of a linear operator with vectors and is a fix for issue #278 .
To avoid adding additional dependencies, the chainrules are implemented in the extension
LinearOperatorsChainRulesCoreExt. Thus, they will only be loaded if the moduleChainRulesCoreis loaded. This cooresponds to the approach taken byAbstractFFTs.jl.So far, this PR contains chainrules for the functions
*(op::AbstractLinearOperator{T}, v::AbstractVector{S})and*(v::Union{Transpose{S, V}, Adjoint{S, V}}, op::AbstractLinearOperator{T}). There might exist further functions for which a chainrule might be useful, but to me these two appeared to contain most use-cases for the combination Zygote.jl / LinearOperators.jl