Fix a bug in the derived adjoint #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 15 15
Lines 1051 1052 +1
=======================================
+ Hits 1015 1016 +1
Misses 36 36 ☔ View full report in Codecov by Sentry. |
|
geoffroyleconte
approved these changes
Dec 8, 2023
dpo
requested changes
Dec 8, 2023
test/test_adjtrans.jl
Outdated
| A = rand(5, 3) + im * rand(5, 3) | ||
|
|
||
| opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
| (y,x) -> (mul!(y,A,x)), |
There was a problem hiding this comment.
Suggested change
| (y,x) -> (mul!(y,A,x)), | |
| (y,x) -> mul!(y,A,x), |
test/test_adjtrans.jl
Outdated
|
|
||
| opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
| (y,x) -> (mul!(y,A,x)), | ||
| (x,y) -> (mul!(x,transpose(A),y)), |
There was a problem hiding this comment.
Suggested change
| (x,y) -> (mul!(x,transpose(A),y)), | |
| (x,y) -> mul!(x,transpose(A),y), |
test/test_adjtrans.jl
Outdated
| A = rand(5, 3) + im * rand(5, 3) | ||
|
|
||
| opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
| (y,x) -> (mul!(y,A,x)), |
There was a problem hiding this comment.
Suggested change
| (y,x) -> (mul!(y,A,x)), | |
| (y,x) -> mul!(y,A,x), |
test/test_adjtrans.jl
Outdated
| opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
| (y,x) -> (mul!(y,A,x)), | ||
| nothing, | ||
| (x,y) -> (mul!(x,adjoint(A),y))) |
There was a problem hiding this comment.
Suggested change
| (x,y) -> (mul!(x,adjoint(A),y))) | |
| (x,y) -> mul!(x,adjoint(A),y)) |
|
@dpo: I incorporated the changes you have suggested. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #302