-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in the derived adjoint #304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 15 15
Lines 1051 1052 +1
=======================================
+ Hits 1015 1016 +1
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @dpo you can merge if this looks good to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just a few minor comments.
test/test_adjtrans.jl
Outdated
A = rand(5, 3) + im * rand(5, 3) | ||
|
||
opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
(y,x) -> (mul!(y,A,x)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(y,x) -> (mul!(y,A,x)), | |
(y,x) -> mul!(y,A,x), |
test/test_adjtrans.jl
Outdated
|
||
opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
(y,x) -> (mul!(y,A,x)), | ||
(x,y) -> (mul!(x,transpose(A),y)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(x,y) -> (mul!(x,transpose(A),y)), | |
(x,y) -> mul!(x,transpose(A),y), |
test/test_adjtrans.jl
Outdated
A = rand(5, 3) + im * rand(5, 3) | ||
|
||
opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
(y,x) -> (mul!(y,A,x)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(y,x) -> (mul!(y,A,x)), | |
(y,x) -> mul!(y,A,x), |
test/test_adjtrans.jl
Outdated
opA = LinearOperator{eltype(A)}(size(A,1), size(A,2), false, false, | ||
(y,x) -> (mul!(y,A,x)), | ||
nothing, | ||
(x,y) -> (mul!(x,adjoint(A),y))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(x,y) -> (mul!(x,adjoint(A),y))) | |
(x,y) -> mul!(x,adjoint(A),y)) |
@dpo: I incorporated the changes you have suggested. Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes Issue #302