Skip to content

Commit

Permalink
chore: only dockerhub login if secret exists
Browse files Browse the repository at this point in the history
  • Loading branch information
Julusian committed Jul 1, 2024
1 parent f9a23be commit 26d8819
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 0 additions & 3 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,5 @@ updates:
directory: "/"
schedule:
interval: "daily"
# Labels on pull requests for security and version updates
labels:
- "type/dependencies"
# Disable version updates for npm dependencies (we only want security updates)
open-pull-requests-limit: 0
4 changes: 3 additions & 1 deletion .github/workflows/node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ jobs:

- name: Login to Docker Hub
uses: docker/login-action@v3
if: matrix.docker-arch
if: ${{ matrix.docker-arch }} && ${{ env.dockerhub_username != '' }}
env:
dockerhub_username: ${{ secrets.DOCKERHUB_USERNAME }}
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
Expand Down

0 comments on commit 26d8819

Please sign in to comment.