Skip to content

Commit

Permalink
Fixes for android && IOS (#1)
Browse files Browse the repository at this point in the history
* Fix : Unable to PrintToPrinter in IOS15 katzer#281

See katzer#281 (comment)

* Fix : pick method returns null in IOS15 katzer#268

See katzer#268

* Fix : Unable to PrintToPrinter in AndroidX

---------

Co-authored-by: IACHI Dimitri Fabien <[email protected]>
  • Loading branch information
KK998 and dimer47 committed Mar 13, 2023
1 parent 672d804 commit 62689fc
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 22 deletions.
4 changes: 2 additions & 2 deletions src/android/PrintAdapter.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ Licensed to the Apache Software Foundation (ASF) under one
import android.print.PrintAttributes;
import android.print.PrintDocumentAdapter;
import android.print.PrintDocumentInfo;
import android.support.annotation.NonNull;
import android.support.v4.print.PrintHelper;
import androidx.annotation.NonNull;
import androidx.print.PrintHelper;

import java.io.FileOutputStream;
import java.io.IOException;
Expand Down
4 changes: 2 additions & 2 deletions src/android/PrintContent.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ Licensed to the Apache Software Foundation (ASF) under one
import android.content.Context;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

import java.io.BufferedInputStream;
import java.io.IOException;
Expand Down
4 changes: 2 additions & 2 deletions src/android/PrintIO.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ Licensed to the Apache Software Foundation (ASF) under one
import android.content.res.Resources;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import android.util.Base64;

import java.io.ByteArrayInputStream;
Expand Down
6 changes: 3 additions & 3 deletions src/android/PrintManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ Licensed to the Apache Software Foundation (ASF) under one
import android.print.PrintAttributes;
import android.print.PrintDocumentAdapter;
import android.print.PrintJob;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v4.print.PrintHelper;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.print.PrintHelper;
import android.webkit.CookieManager;
import android.webkit.WebSettings;
import android.webkit.WebView;
Expand Down
12 changes: 6 additions & 6 deletions src/android/PrintOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ Licensed to the Apache Software Foundation (ASF) under one
package de.appplant.cordova.plugin.printer;

import android.print.PrintAttributes;
import android.support.annotation.NonNull;
import android.support.v4.print.PrintHelper;
import androidx.annotation.NonNull;
import androidx.print.PrintHelper;

import org.json.JSONObject;

Expand All @@ -35,10 +35,10 @@ Licensed to the Apache Software Foundation (ASF) under one
import static android.print.PrintAttributes.MediaSize.UNKNOWN_LANDSCAPE;
import static android.print.PrintAttributes.MediaSize.UNKNOWN_PORTRAIT;
import static android.print.PrintDocumentInfo.PAGE_COUNT_UNKNOWN;
import static android.support.v4.print.PrintHelper.ORIENTATION_LANDSCAPE;
import static android.support.v4.print.PrintHelper.ORIENTATION_PORTRAIT;
import static android.support.v4.print.PrintHelper.SCALE_MODE_FILL;
import static android.support.v4.print.PrintHelper.SCALE_MODE_FIT;
import static androidx.print.PrintHelper.ORIENTATION_LANDSCAPE;
import static androidx.print.PrintHelper.ORIENTATION_PORTRAIT;
import static androidx.print.PrintHelper.SCALE_MODE_FILL;
import static androidx.print.PrintHelper.SCALE_MODE_FIT;

/**
* Wrapper for the print job settings.
Expand Down
4 changes: 2 additions & 2 deletions src/android/PrintProxy.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ Licensed to the Apache Software Foundation (ASF) under one
import android.print.PageRange;
import android.print.PrintAttributes;
import android.print.PrintDocumentAdapter;
import android.support.annotation.NonNull;
import android.support.v4.print.PrintHelper;
import androidx.annotation.NonNull;
import androidx.print.PrintHelper;

/**
* Simple delegate class to have access to the onFinish method.
Expand Down
4 changes: 2 additions & 2 deletions src/android/Printer.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ Licensed to the Apache Software Foundation (ASF) under one

package de.appplant.cordova.plugin.printer;

import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import android.webkit.WebView;

import org.apache.cordova.CallbackContext;
Expand Down
7 changes: 5 additions & 2 deletions src/ios/APPPrinter.m
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,12 @@ - (void) printContent:(NSString *)content
withSettings:(NSDictionary *)settings
{
__block id item;
__block UIPrintInteractionController* ctrl;

UIPrintInteractionController* ctrl =
[UIPrintInteractionController sharedPrintControllerWithSettings:settings];
dispatch_sync(dispatch_get_main_queue(), ^{
ctrl =
[UIPrintInteractionController sharedPrintControllerWithSettings:settings];
});

ctrl.delegate = self;

Expand Down
2 changes: 1 addition & 1 deletion www/printer.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

var exec = require('cordova/exec'),
ua = navigator.userAgent.toLowerCase(),
isIOS = ua.indexOf('ipad') > -1 || ua.indexOf('iphone') > -1;
isIOS = ua.indexOf('ipad') > -1 || ua.indexOf('iphone') > -1 || window.cordova.platformId === "ios";

// Defaults
exports._defaults = {
Expand Down

0 comments on commit 62689fc

Please sign in to comment.