Skip to content

Commit

Permalink
feat: remove macos bounds for reading and writing audio metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
KRTirtho committed Sep 12, 2022
1 parent 5866b0f commit 16064f6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
12 changes: 0 additions & 12 deletions lib/components/Library/UserLocalTracks.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:spotube/models/CurrentPlaylist.dart';
import 'package:spotube/models/Logger.dart';
import 'package:spotube/provider/Playback.dart';
import 'package:spotube/provider/UserPreferences.dart';
import 'package:spotube/utils/platform.dart';
import 'package:spotube/utils/primitive_utils.dart';
import 'package:spotube/utils/type_conversion_utils.dart';

Expand Down Expand Up @@ -45,17 +44,6 @@ final localTracksProvider = FutureProvider<List<Track>>((ref) async {
}
final entities = downloadDir.listSync(recursive: true);

// TODO: Add MacOS audiotag reading support
if (kIsMacOS) {
return entities
.map(
(entity) => TypeConversionUtils.localTrack_X_Track(
File(entity.path),
),
)
.toList();
}

final filesWithMetadata = (await Future.wait(
entities.map((e) => File(e.path)).where((file) {
final mimetype = lookupMimeType(file.path);
Expand Down
4 changes: 0 additions & 4 deletions lib/provider/Downloader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:spotube/models/SpotubeTrack.dart';
import 'package:spotube/provider/Playback.dart';
import 'package:spotube/provider/UserPreferences.dart';
import 'package:spotube/provider/YouTube.dart';
import 'package:spotube/utils/platform.dart';
import 'package:spotube/utils/type_conversion_utils.dart';
import 'package:youtube_explode_dart/youtube_explode_dart.dart' hide Comment;

Expand Down Expand Up @@ -94,9 +93,6 @@ class Downloader with ChangeNotifier {
"[addToQueue] Download of ${file.path} is done successfully",
);

// TODO: Add MacOS audiotag writing support
if (kIsMacOS) return;

logger.v(
"[addToQueue] Writing metadata to ${file.path}",
);
Expand Down

0 comments on commit 16064f6

Please sign in to comment.