Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add option to select Genius as default for lyrics #182

Closed
1 task done
PlotCitizen opened this issue Aug 25, 2022 · 1 comment
Closed
1 task done

[Feature] Add option to select Genius as default for lyrics #182

PlotCitizen opened this issue Aug 25, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request invalid/out-of-scope This doesn't seem right (or out of scope)

Comments

@PlotCitizen
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Category of the Feature

UI Improvements, Logical Improvements, More Efficiency

Credits

None

Pain

If you are listening to a playlist while on the "Lyrics" tab and you change the song, a pop-up comes up saying:

The found lyrics might not be properly synced. Do you want to default to static (genius.com) lyrics? Hint: Wait for a moment to see if the lyrics actually sync. Sometimes it may sync.

You need to either press "No" or "Yes" so you can clearly see the lyrics behind the pop-up and this can get annoying, especially if you are fine with no lyric syncing capabilities.

Suggested Solution

During my time using Spotube, it seems like the matching process for finding song lyrics via Genius tends to be more accurate than the other option (RentAnAdviser, I believe), but obviously the downside of the Genius method is that there is no syncing.

Ideally, users who don't care too much about syncing could just select to always use Genius somewhere in the settings. This way, there would be no need to keep deciding which source for lyrics you want to use for every song that you listen to. Of course, there is also the issue of missing lyrics for less popular songs - perhaps if the lyrics are not found on Genius, then it can fall back to the other option (assuming that they are found on the other option).

Useful resources/references

No response

@PlotCitizen PlotCitizen added enhancement New feature or request good first issue labels Aug 25, 2022
KRTirtho added a commit that referenced this issue Oct 24, 2022
refactor: remove code-style warnings
@KRTirtho KRTirtho added this to To do in New Features via automation Oct 24, 2022
@KRTirtho KRTirtho moved this from To do to Done in New Features Oct 24, 2022
@KRTirtho KRTirtho added the invalid/out-of-scope This doesn't seem right (or out of scope) label Mar 8, 2023
@KRTirtho
Copy link
Owner

KRTirtho commented Mar 8, 2023

Luckily, this feature isn't needed anymore as Spotube now uses Official Spotify (Musixmatch) lyrics. So we dropped genius.com and rentanadviser.com support in favor of it

@KRTirtho KRTirtho closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid/out-of-scope This doesn't seem right (or out of scope)
Projects
Status: Won't be possible
Development

No branches or pull requests

2 participants