-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update pkgver using makepkg #24
base: master
Are you sure you want to change the base?
Conversation
ab59c61
to
d264704
Compare
d264704
to
f0c680f
Compare
9988ac9
to
e6f7194
Compare
It seems that you're busy. Notify me by |
bc58083
to
8befa3b
Compare
8befa3b
to
ddea9b0
Compare
Hi @KSXGitHub Is it ready to merge this PR? |
cd /tmp/makepkg; | ||
makepkg -od; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;
is unnecessary.
if [ "$update_pkgver" = "true" ]; then | ||
echo '::group::Updating pkgver' | ||
echo 'Running `makepkg -od` to update pkgver' | ||
mkdir -p /tmp/makepkg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a command called mktemp
that always exists (provided by the coreutils
package). It is better to use that than mkdir -p /tmp/makepkg
.
@KSXGitHub I submitted another PR (#26) for updating the |
If a
pkgver()
function exists, the PKGBUILD file will be copied into a new temporary directory,makepkg -od
will be run, and then the new PKGBUILD file will be the one that is copied into the aur repo.makepkg -od
:-o
skips building, but still runspkgver()
-d
skips dependency checks, which is fine as long as no dependencies (other than git) are used in thepkgver()
function