COMP: Updating the Slicer tag to the nightly of Sept 13 #30
Conversation
|
@laurapascal , @vicory : Could you guys please review after Laura is done checking? |
|
Hi @hina-shah we have done some changes to update all extensions to Qt5. @vicory is working on testing the current packaged extensions with VTK8, if they require a lot of changes, we will freeze the Slicer version to the one that includes the upgrade to Qt5 only. We are facing our first SlicerSALT release early spring next year, and this might delay developement even more. We will keep you posted, thanks! |
|
My bad: It looks like the folder that compiles vtk, is named "VTKv8", but internally it is still compiling VTK7. I'll bring it up in the Slicer forum. But with the changes in this pull request, we are still at vtk7 and qt4. So we should be kosher for now. Also, without these changes, I wasn't able to compile SlicerSALT on my MacOS Sierra. So this would really help fresh compilations. |
|
Hi @hina-shah, @laurapascal is going to do a new PR with the release tag of Slicer, after testing that everything still works. Closing this PR, but thank you so much for contributing! |
Jared Vicory (1):
ENH: Rename files to fix Windows compilation issues
Jean-Christophe Fillion-Robin (12):
COMP: Refiner: Fix build error using nullptr
COMP: Refiner: Fix build error using "std::abs" instead of "abs"
COMP: Refiner: Fix unused-variable and unused-parameter warnings
COMP: Refiner: Fix sign-compare warnings
COMP: Refiner: Fix -Wmaybe-uninitialized warnings in vtkPolyData2ImageData
COMP: Refiner: Use nullptr and override keywords
COMP: Initializer: Fix unused-variable warning
COMP: Refiner: Fix object name in UI file
STYLE: Remove trailing whitespaces
STYLE: Expand tabs into four spaces
Merge pull request Kitware#29 from jcfr/cleanup-whitespaces
Merge branch 'misc-tweaks'
Zhiyuan (1):
Add support for converting SALT srep to legacy sreps
Zhiyuan Liu (20):
Improve SkeletalRepresentationRefiner and SkeletalRepresentationVisualizer
Merge pull request Kitware#27 from KitwareMedical/ENH_refinement-rebased
STYLE: Remove redundant file
COMP: C++11: Update source code to use nullptr
STYLE: .gitgnore: Fix regex excluding QtCreator project file
COMP: Refiner: Fix sign-compare and implicit conversion warnings
ENH: Update module title, contributor list and acknowledgment
ENH: Add support for saving initialized s-rep including fix connection of fold curve
Merge pull request Kitware#30 from KitwareMedical/ENH_refinement-rebased-2
remove unused functions and variables; resolve some compile warnings
Merge pull request Kitware#31 from ZhiyLiu/code_review
new features and fix in initializer
COMP: new feature (set the skeleton resolution) and fix in initializer
COMP: update readme to include more instructions of using the refiner and initializer
COMP: upload a screenshot to illustrate the result from the initializer
COMP: add a picture to illustrate operations in this extension
BUG: fix variable length of arrays to satisfy compiler in visusal studio
Merge pull request Kitware#38 from ZhiyLiu/ENH_interpolate
Reparametrize initial s-reps; Fix problems in the interpolation and refinement; Refine readme.md
Merge branch 'master' into COMP_fix_refinement
vicory (2):
Merge pull request Kitware#40 from ZhiyLiu/COMP_fix_refinement
Merge pull request Kitware#41 from vicory/compilation_fixes
@laurapascal : Could you please check if SPHARM and Shape population viewer run correctly under these changes? With this change, VTK8 would be compiled and used for all the extensions.