Remove QtWebEngineCore.framework #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
remove-QtWebEngineCore.framework
branch
2 times, most recently
from
5116fb9
to
b68c5cd
Compare
jcfr
force-pushed
the
remove-QtWebEngineCore.framework
branch
2 times, most recently
from
02e6871
to
21bbcda
Compare
jcfr
force-pushed
the
remove-QtWebEngineCore.framework
branch
from
21bbcda
to
301608d
Compare
This commit allows to workaround codesign error for package built with Slicer_BUILD_WEBENGINE_SUPPORT set to OFF. This is required for signing Slicer (or Slicer-based) package prior Slicer/Slicer@b0e0361be (2022.11.21) introduced through Slicer/Slicer#6685.
jcfr
force-pushed
the
remove-QtWebEngineCore.framework
branch
from
301608d
to
fb7828a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows to workaround
codesignerror for package built withSlicer_BUILD_WEBENGINE_SUPPORTset toOFF.