Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for TRV602 #6766

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Add full support for TRV602 #6766

merged 2 commits into from
Dec 26, 2023

Conversation

lompi
Copy link
Contributor

@lompi lompi commented Dec 24, 2023

This pull request adds full support for the TRV602 device. Until now, support for this device was added using the existing configuration, but this device does not support boost mode and gives the possibility to control screen orientation and display brightness.

tuyaDatapoints: [
[1, null,
{
from: (v) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to a value converter in lib/tuya.ts and also use it for TS0601_thermostat_1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I moved that. I hope that it's ok, because js isn't my technology and I did it by feel.

@Koenkk Koenkk merged commit c4dedf1 into Koenkk:master Dec 26, 2023
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 26, 2023

Thanks!

@BAUBLITZ
Copy link

the TRV602 has an additional function that is still missing in tuya.js.
The “eco” and “comfort” functions. In "eco" the thermostat regulates the temperature by completely opening and closing the valve. With the "comfort" function, the thermostat regulates the temperature much more precisely because the valve is opened or closed to different extents depending on the difference between the set and the actual temperature.

To do this, the following must be added under exposes:

e.enum('mode', ea.STATE_SET, ['comfort', 'eco']).withDescription('Hysteresis - comfort > switches off/on exactly at reached temperature with valve smooth from 0 to 100%, eco > 0.5 degrees above or below, valve either 0 or 100%'),

an under tuyaDatapoints:

[114, 'mode', tuya.valueConverterBasic.lookup({'comfort': tuya.enum(0), 'eco': tuya.enum(1)})],

Can someone still integrate this?

Koenkk added a commit that referenced this pull request Jan 21, 2024
@Koenkk
Copy link
Owner

Koenkk commented Jan 21, 2024

@BAUBLITZ done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants