-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full support for TRV602 #6766
Conversation
src/devices/tuya.ts
Outdated
tuyaDatapoints: [ | ||
[1, null, | ||
{ | ||
from: (v) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this to a value converter in lib/tuya.ts
and also use it for TS0601_thermostat_1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I moved that. I hope that it's ok, because js isn't my technology and I did it by feel.
Thanks! |
the TRV602 has an additional function that is still missing in tuya.js. To do this, the following must be added under exposes: e.enum('mode', ea.STATE_SET, ['comfort', 'eco']).withDescription('Hysteresis - comfort > switches off/on exactly at reached temperature with valve smooth from 0 to 100%, eco > 0.5 degrees above or below, valve either 0 or 100%'), an under tuyaDatapoints: [114, 'mode', tuya.valueConverterBasic.lookup({'comfort': tuya.enum(0), 'eco': tuya.enum(1)})], Can someone still integrate this? |
@BAUBLITZ done! |
This pull request adds full support for the TRV602 device. Until now, support for this device was added using the existing configuration, but this device does not support boost mode and gives the possibility to control screen orientation and display brightness.