Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nexelec file to support Open'R product #6890

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

ElouanHocineNexelec
Copy link
Contributor

I also created a request for a picture and documentation in zigbee2mqtt.io

We had clients asking for support for one of our product, so here's the file!
We're also makinjg a pull request for the picture and description at the same time.
@Koenkk
Copy link
Owner

Koenkk commented Jan 13, 2024

Can you try to generate the definition with the latest dev branch and see if that works?

Note to self; after this merge Koenkk/zigbee2mqtt.io#2487

@ElouanHocineNexelec
Copy link
Contributor Author

ElouanHocineNexelec commented Jan 23, 2024

When i try to generate the definition on Zigbee2MQTT Edge with the nexelec.js file added in the external converters, i get this result :
Capture d'écran 2024-01-23 115022

Is this what you expected?

@Koenkk
Copy link
Owner

Koenkk commented Jan 23, 2024

Yes, does the definition work?

@ElouanHocineNexelec
Copy link
Contributor Author

ElouanHocineNexelec commented Jan 24, 2024

The definition works partially, i edited it a little (Modified product description, model and removed some identify() with no adverse effects)
Values are exposed correctly, but Co2 values seems abnormal :
image
Fresh air is around 400ppm, I'm in an office where the value should be between 900 and 1200ppm.
Co2 values were correct in the first iteration of the nexelec.js file.

Koenkk added a commit that referenced this pull request Jan 24, 2024
@Koenkk
Copy link
Owner

Koenkk commented Jan 24, 2024

I think it needs to be multiplied by 10, fixed that now, can you check again with latest-dev?

Changes will be available in the dev branch in a few hours from now.

@ElouanHocineNexelec
Copy link
Contributor Author

ElouanHocineNexelec commented Jan 25, 2024

I've tried it just then on Zigbee2MQTT Edge, so i recon the changes were applied to it.
Values on my products are now between 9 and 11ppm.
image
I think your first hunch about the value was right, but on this update it has been divided by 10 somehow.

Koenkk added a commit that referenced this pull request Jan 25, 2024
@Koenkk
Copy link
Owner

Koenkk commented Jan 25, 2024

Whoops, pushed a fix.

Changes will be available in the dev branch in a few hours from now.

@ElouanHocineNexelec
Copy link
Contributor Author

ElouanHocineNexelec commented Jan 26, 2024

Seems like all the extends works now! I've updated nexelec.ts for it to comply with the modernExtend import, everything should be working fine.
I have two questions :
-It seems now that the products aren't displayed on the dashboard. Here's an example of what it looked like using the first version of nexelec.js in the picture below, but if i use the modernExtend version it displays nothing, is this to be expected?
image

-When will the vendor file will be compatible with the Main Zigbee2MQTT branch?

Thank you very much for all your help!

@Koenkk
Copy link
Owner

Koenkk commented Jan 26, 2024

t seems now that the products aren't displayed on the dashboard. Here's an example of what it looked like using the first version of nexelec.js in the picture below, but if i use the modernExtend version it displays nothing, is this to be expected?

Can you open an issue in the frontend repo for this?

-When will the vendor file will be compatible with the Main Zigbee2MQTT branch?

Next release is 1 Feb

@Koenkk Koenkk merged commit a95f998 into Koenkk:master Jan 26, 2024
2 checks passed
@ElouanHocineNexelec
Copy link
Contributor Author

It's open!

Thank you again for all your help, it was nice collaborating with you!
Until i need your help again,
Be well.

@WhistleMaster
Copy link

Hi !

Trying to get a new value from the UI through the "Exposes" tab of a Nexelec / Netsecur device will through the following error:

Screenshot 2024-02-17 at 08 53 21

The device is reporting correctly the values, but forcing to get one, temperature, humidity, CO2 or battery will pop this same error.

@Dylan-DutchAndBold
Copy link

@ElouanHocineNexelec Just wanted to say I really appreciate the effort to add it to zigbee2mqtt. This is the reason I have purchased the device and it works like a charm.

@WhistleMaster I have set it up today with the latest version of koenkk/zigbee2mqtt and did not get those errors, neither when I press the refresh button next to the values.

@ElouanHocineNexelec
Copy link
Contributor Author

@WhistleMaster I can see this issue happening for CO2 and Battery but not Humidity, i'll look into it and open a issue as not to pollute this ticket. Thank you for the feedback, I'll try to keep you updated about it.

@Dylan-DutchAndBold thank you for the feedback as well, means a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants