Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OTA #7585

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Optimize OTA #7585

merged 6 commits into from
Jun 4, 2024

Conversation

Nerivec
Copy link
Contributor

@Nerivec Nerivec commented May 31, 2024

  • Convert logic to async/await
  • Add mock to test actual update logic
    • for now local only, takes too long for CI, even with fake timers that bypass throttling
  • Move existing tests to TS
  • Fix code styling, add typing, remove magic numbers for ZCL spec.

TODO:

  • Better mock/test to allow CI testing of update (see above)?
  • Test with actual device
  • Test with devices known to have OTA quirks (Legrand, Sonoff, Bosch...)

@Nerivec
Copy link
Contributor Author

Nerivec commented May 31, 2024

Tests by @mundschenk-at (on network of ~80 devices)

Notes:

  • ETA appears to become pretty good around the 10% mark. A bit over-estimated before then.

src/lib/ota/common.ts Outdated Show resolved Hide resolved
@Nerivec Nerivec marked this pull request as ready for review June 4, 2024 18:08
Koenkk added a commit that referenced this pull request Jun 4, 2024
@Koenkk Koenkk merged commit d96e000 into Koenkk:master Jun 4, 2024
2 checks passed
@Nerivec Nerivec deleted the optimize-ota branch June 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants