Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use herdsman improved looping. #23541

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Use herdsman improved looping. #23541

merged 4 commits into from
Aug 8, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Aug 6, 2024

Implements changes from Koenkk/zigbee-herdsman#1130

The devices logging loop change in controller is not strictly necessary, but it allows to remove the function in zigbee since it then no longer is used.

Also improved a few bits in network map.

@Nerivec
Copy link
Collaborator Author

Nerivec commented Aug 7, 2024

Sidenote: @Koenkk Also need to remove the transmit power on startup since it's in herdsman now Koenkk/zigbee-herdsman#1139 (btw, can probably remove it from the Adapter API too and just let each stack handle it)

if (settings.get().advanced.hasOwnProperty('transmit_power')) {

@Koenkk Koenkk merged commit 13ac8a0 into Koenkk:dev Aug 8, 2024
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Aug 8, 2024

Sidenote: @Koenkk Also need to remove the transmit power on startup since it's in herdsman now

Yes, still on my to-do list

Thanks for the PR!

@Nerivec Nerivec deleted the herdsman-loops branch August 8, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants