Merge branch 'release/1.1.2'

Kofktu · Jan 26, 2019 · 2d44869 · 2d44869
2 parents a884839 + 3566eb6
commit 2d44869
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/Example/ViewController.swift b/Example/ViewController.swift
@@ -58,7 +58,7 @@ class ViewController: UIViewController {
     @IBAction func onPopOverNavigationViewController(_ sender: UIButton) {
         let storyboard = UIStoryboard(name: "Main", bundle: nil)
         let viewController = storyboard.instantiateViewController(withIdentifier: "CustomPushViewController") as! CustomPushViewController
-        viewController.showPopover(withNavigationController: sender, shouldDismissOnTap: false)
+        viewController.showPopoverWithNavigationController(sourceView: sender, shouldDismissOnTap: false)
     }
 }
 

diff --git a/KUIPopOver.podspec b/KUIPopOver.podspec
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
   #
 
   s.name         = "KUIPopOver"
-  s.version      = "1.1.1"
+  s.version      = "1.1.2"
   s.summary      = "Easy to use PopOver in iOS"
 
   # This description is used to generate tags and improve search results.

diff --git a/KUIPopOver/Classes/KUIPopOver.swift b/KUIPopOver/Classes/KUIPopOver.swift
@@ -128,7 +128,7 @@ extension KUIPopOverUsable where Self: UIViewController {
         rootViewController?.present(self, animated: true, completion: completion)
     }
 
-    public func showPopover(withNavigationController sourceView: UIView, sourceRect: CGRect? = nil, shouldDismissOnTap: Bool = true, completion: ShowPopoverCompletion? = nil) {
+    public func showPopoverWithNavigationController(sourceView: UIView, sourceRect: CGRect? = nil, shouldDismissOnTap: Bool = true, completion: ShowPopoverCompletion? = nil) {
         let naviController = popOverUsableNavigationController
         naviController.popoverPresentationController?.sourceView = sourceView
         naviController.popoverPresentationController?.sourceRect = sourceRect ?? sourceView.bounds
@@ -142,7 +142,7 @@ extension KUIPopOverUsable where Self: UIViewController {
         rootViewController?.present(self, animated: true, completion: completion)
     }
 
-    public func showPopover(withNavigationController barButtonItem: UIBarButtonItem, shouldDismissOnTap: Bool = true, completion: ShowPopoverCompletion? = nil) {
+    public func showPopoverWithNavigationController(barButtonItem: UIBarButtonItem, shouldDismissOnTap: Bool = true, completion: ShowPopoverCompletion? = nil) {
         let naviController = popOverUsableNavigationController
         naviController.popoverPresentationController?.barButtonItem = barButtonItem
         KUIPopOverDelegation.shared.shouldDismissOnOutsideTap = shouldDismissOnTap

diff --git a/KUIPopOver/Info.plist b/KUIPopOver/Info.plist
@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.1.1</string>
+	<string>1.1.2</string>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>NSPrincipalClass</key>

diff --git a/README.md b/README.md
@@ -70,9 +70,9 @@ public func dismissPopover(animated: Bool, completion: DismissPopoverCompletion?
 
 ```swift
 public func showPopover(sourceView: UIView, sourceRect: CGRect?, completion: ShowPopoverCompletion?)
-public func showPopover(withNavigationController sourceView: UIView, sourceRect: CGRect?, completion: ShowPopoverCompletion?)
+public func showPopoverWithNavigationController(sourceView: UIView, sourceRect: CGRect?, completion: ShowPopoverCompletion?)
 public func showPopover(barButtonItem: UIBarButtonItem, completion: ShowPopoverCompletion?)
-public func showPopover(withNavigationController barButtonItem: UIBarButtonItem, completion: ShowPopoverCompletion?)
+public func showPopoverWithNavigationController(barButtonItem: UIBarButtonItem, completion: ShowPopoverCompletion?)
 public func dismissPopover(animated: Bool, completion: DismissPopoverCompletion?)
 ```
 
@@ -113,7 +113,7 @@ customViewController.showPopover(sourceView: sender, sourceRect: sender.bounds)
 customViewController.showPopover(barButtonItem: sender)
 
 // with NavigationController
-customViewController.showPopover(withNavigationController: sender, sourceRect: sender.bounds)
+customViewController.showPopoverWithNavigationController(sourceView: sender, sourceRect: sender.bounds)
 
 customViewController.dismissPopover(animated: true)
 customViewController.dismissPopover(animated: true, completion: {