-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend log filtering #1725
extend log filtering #1725
Conversation
f940fb4
to
ed5c72b
Compare
I am not sure if wasm side will be as stable as before. @yurii-khi could be nice if you can test/check this for wasm |
Hey! Do you have any specific test-cases in mind, or just general smoke testing? |
Just log specific testing for wasm. I want to make sure I didn't break any of the log functionality for wasm |
Right now it breaks our logger, most probably because of missing |
Because
Can you provide me very simple js code for testing this logging thing? @yurii-khi |
I think best way would be to use exact js file we're using on webdex side: But I'd recommend to install flutter and run app locally, it's very simple and will provide reliable results. |
We removed the custom What happens if I remove it for wasm as well? I removed them in this PR and need a feedback from gui team. Does For testing it, https://github.com/KomodoPlatform/WebDEX/blob/b8f05db785783889e659ea67f36dd7313f76d55c/web/src/index.js#L37 this line needs to be removed with |
I think we can get rid of it on our side as well, just need to wait until changes propagate to dev branch. |
It can be nice if you can test this branch on gui side for wasm, to see if there is nothing wrong after removing |
Tested
|
It turns out doing that will likely increase compexicty to higher levels. This requires much more refactoring than I expected. I will only keep enabling |
ed5c72b
to
1bfd6b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Signed-off-by: ozkanonur <[email protected]>
8fc09c0
to
6c4ab77
Compare
…able-log-management
The custom log filtering implementation limits users for no reason. We already have
env_logger
in our dependency tree. With this PR, we will be able to change log level for any module fromRUST_LOG
.e.g:
export RUST_LOG="debug,atomicdex_gossipsub::behaviour=off,crypto::crypto_ctx=warn"
Global default filter is "info". If you want to debug specific module for example
atomicdex_gossipsub::behaviour
and nothing else, you can doexport RUST_LOG="info,atomicdex_gossipsub::behaviour=debug"
and that will keep default level as info with printing debug logs fromatomicdex_gossipsub::behaviour
.cc @Alrighttt