Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas limit options #287

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add gas limit options #287

wants to merge 3 commits into from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Jul 17, 2024

Adds notes for gas_limit param object as detailed in KomodoPlatform/komodo-defi-framework#2137

Copy link

Preview for merge commit: 5088be6, available on cloudflare at: https://3f96d176.komodo-docs.pages.dev/en/docs/

smk762 and others added 2 commits July 17, 2024 09:22
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Copy link

Preview for merge commit: 8283156, available on cloudflare at: https://ef1b6bde.komodo-docs.pages.dev/en/docs/

| Parameter | Type | Description |
| ----------------------------------------- | ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| chain\_id | integer | To find the EVM chain ID, see [Chainlist](https://chainlist.org/) |
| gas\_limit | object | Optional, required for tokens only. Defines more precise gas prices for swap or transaction operations, useful for tokens called ovcer proxy contracts which often require more than the default gas. See the `Gas Limit Options` table below for more information. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful for tokens called ovcer proxy contracts which often require more than the default gas.

It's used for the reverse of this actually, we use default limits that allow tokens that use proxy contracts but we can use these parameters to lower limits for other tokens if needed. @dimxy please confirm this and also give this docs PR a review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes all gas_limit params are optional and internally set to default values (which maybe too high for certain tokens, so could be tuned for new or existing evm tokens)

Copy link

@dimxy dimxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

| Parameter | Type | Description |
| ----------------------------------------- | ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| chain\_id | integer | To find the EVM chain ID, see [Chainlist](https://chainlist.org/) |
| gas\_limit | object | Optional, required for tokens only. Defines more precise gas prices for swap or transaction operations, useful for tokens called ovcer proxy contracts which often require more than the default gas. See the `Gas Limit Options` table below for more information. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes all gas_limit params are optional and internally set to default values (which maybe too high for certain tokens, so could be tuned for new or existing evm tokens)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants