Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/gas fee estimator docs #293

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from
Draft

Conversation

harsenyan3
Copy link
Collaborator

Added docs for:
1. start_gas_fee_estimator
2. stop_gas_fee_estimator
3. get_eth_estimated_fee_per_gas
Copy link
Contributor

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the latest release, I am unable to get a response from these methods.

  • get_eth_estimated_fee_per_gas -> Gas fee estimation not supported for this coin
  • start_gas_fee_estimator -> NoSuchMethod
  • stop_gas_fee_estimator -> NoSuchMethod

cc: @dimxy

@smk762 smk762 requested a review from dimxy September 9, 2024 06:14
@dimxy
Copy link

dimxy commented Sep 9, 2024

  • start_gas_fee_estimator

Sorry, I renamed those rpcs to

start_eth_fee_estimator
stop_eth_fee_estimator

(btw I have a bug when the eth fee estimator does not start if the new 'enable_eth_with_tokens' rpc was used to enable coins, it starts okay only if the old 'enable' rpc used. Fixed in my current work for access lists #2170)

Copy link

github-actions bot commented Sep 9, 2024

Preview for merge commit: dde5272, available on cloudflare at: https://f751e334.komodo-docs.pages.dev/en/docs/

@smk762 smk762 added P1 Important task which needs to be completed soon KDF 2.2.0-beta awaiting review and removed v2.1.0-beta-changelog labels Sep 13, 2024
@smk762 smk762 marked this pull request as draft September 13, 2024 08:39
@smk762
Copy link
Contributor

smk762 commented Sep 13, 2024

Set to "draft" until KomodoPlatform/komodo-defi-framework#2170 (comment) is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review KDF 2.2.0-beta P1 Important task which needs to be completed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants