Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Add nft docs #42

Merged
merged 114 commits into from
Mar 4, 2024
Merged

[r2r] Add nft docs #42

merged 114 commits into from
Mar 4, 2024

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented May 17, 2023 •
edited

Closes #43

  • get_nft_list
  • get_nft_transfers
  • get_nft_metadata
  • update_nft
  • withdraw_nft (erc721)
  • withdraw_nft (erc1155)
  • clearing the nft database tables
  • querying the nft database tables

@smk762 smk762 requested review from gcharang and laruh May 17, 2023 06:33
@smk762 smk762 changed the title Add nft docs [r2r] Add nft docs May 17, 2023
@smk762 smk762 added new docs P0 Critical issue that needs to be fixed P1 Important task which needs to be completed soon and removed P0 Critical issue that needs to be fixed labels May 17, 2023
laruh
laruh requested changes May 18, 2023
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
This is first review iteration, I will provide more notes later.

src/pages/atomicdex/api/v20-dev/non_fungible_tokens/index.mdx Outdated Show resolved Hide resolved
src/pages/atomicdex/api/v20-dev/non_fungible_tokens/index.mdx Outdated Show resolved Hide resolved
@smk762 smk762 requested a review from laruh May 25, 2023 09:02
laruh
laruh requested changes May 26, 2023
View reviewed changes
Copy link
Member

@laruh laruh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is second iteration with another notes. I will check more changes from the first later (need more time to check fields types in responses).

src/pages/atomicdex/api/v20-dev/non_fungible_tokens/index.mdx Outdated Show resolved Hide resolved
src/pages/atomicdex/api/v20-dev/non_fungible_tokens/index.mdx Outdated Show resolved Hide resolved
src/pages/atomicdex/api/v20/index.mdx Outdated Show resolved Hide resolved
laruh
laruh requested changes May 26, 2023
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more note

src/pages/atomicdex/api/v20-dev/non_fungible_tokens/index.mdx Outdated Show resolved Hide resolved
@smk762 smk762 requested a review from laruh February 25, 2024 08:41
@smk762
Copy link
Contributor Author

smk762 commented Feb 25, 2024

@gcharang @kivqa Ready for Review
@laruh These docs may need some further work, but we will merge it in soon so we can apply the rebranding from atomicdex in a final PR before publishing without leaving this PR subject to numerous conflicts.
Once rebranding PR is done, review and polish of this PR (alongside the HD Wallet PR) will be top of the list for docs tasks.

@github-actions GitHub Actions
Copy link

Preview for merge commit: 0a3c27a, available on cloudflare at: https://18f83c67.komodo-docs.pages.dev/en/docs/

@github-actions GitHub Actions
Copy link

Preview for merge commit: a882565, available on cloudflare at: https://d0d6fc0a.komodo-docs.pages.dev/en/docs/

@github-actions GitHub Actions
Copy link

Preview for merge commit: 37eb000, available on cloudflare at: https://2df757cc.komodo-docs.pages.dev/en/docs/

@smk762
Copy link
Contributor Author

smk762 commented Feb 29, 2024

Note: The recently added clear_nft_db method specifies the chains parameter as optional. Currently it is required, but will be made optional later based on testing feedback provided to @laruh

@github-actions GitHub Actions
Copy link

Preview for merge commit: 5fa3529, available on cloudflare at: https://67bd223f.komodo-docs.pages.dev/en/docs/

@github-actions GitHub Actions
Copy link

Preview for merge commit: 1e87b7a, available on cloudflare at: https://9fd08596.komodo-docs.pages.dev/en/docs/

gcharang and others added 2 commits February 29, 2024 18:39
@gcharang
Merge branch 'dev' into add-nft-docs
b819972
@gcharang
[Bot] File and author data updated, validated and updated internal li…
7f0bef1 
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update atomicdex methods table
@github-actions GitHub Actions
Copy link

Preview for merge commit: a0924fd, available on cloudflare at: https://d31e2dc0.komodo-docs.pages.dev/en/docs/

@gcharang
Merge pull request #212 from KomodoPlatform/lint-fix-patches/add-nft-…
418d2d4 
…docs

[BOT] PR to add-nft-docs. Lints file structure, file contents, gets author data, Updates AtomicDEX API Methods Table
@github-actions GitHub Actions
Copy link

Preview for merge commit: effef94, available on cloudflare at: https://849a4279.komodo-docs.pages.dev/en/docs/

@gcharang gcharang merged commit 5e15b92 into dev Mar 4, 2024
3 checks passed
@gcharang gcharang deleted the add-nft-docs branch April 12, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcharang gcharang gcharang approved these changes

@kivqa kivqa Awaiting requested review from kivqa

@laruh laruh Awaiting requested review from laruh

Assignees
No one assigned
Labels
new docs P1 Important task which needs to be completed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[new doc] Add NFT methods
3 participants
@smk762 @laruh @gcharang