Integrating contributions from NomicAI for integation to LLama.cpp and GPT4ALL #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually need it.
libkompute.a, ShaderOpMult.hpp, and ShaderLogisticRegression.hpp are not needed at runtime by GPT4All, so don't install them. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: crydsch <[email protected]> (cherry picked from commit 2a9f82a)
Signed-off-by: Jared Van Bortel <[email protected]>
This allows Vulkan instances to be reused, since a program may wish to switch devices, but the NVIDIA driver eventually fails to create Vulkan instances if you call VkFreeInstance/VkDestroyInstance too many times. Signed-off-by: Jared Van Bortel <[email protected]>
Sequences tend to reference tensors, so one cleanup pass is not enough. clear() is most useful if it frees all resources on the device, especially because we can only call VkCreateDevice/VkDestroyDevice so many times before the NVIDIA driver can no longer create devices. Signed-off-by: Jared Van Bortel <[email protected]>
*Technically*, our mat*mat shaders require some level of shader float16 support. Leaving this requirement disabled allows this code to work on more GPUs without issue, but the validation layers report an error in this case. With this change, GPUs that actually claim to support shaderFloat16 should no longer report a validation error. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cebtenzzre creating an initial draft PR for integration of contributinos from NomicAI for integation to LLama.cpp and GPT4ALL as part of nomic-ai/gpt4all#1852.
This PR can serve as an opportunity to dive further into some of the requirements, as well as alignment to the newer updates that have been added since, including the extension of the cmake build system.
Changes included in this PR: