Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.1.13 version #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

g5-freemen
Copy link

Add button to delete selected (old) version (folder) of Minecraft

@ViNi-Arco
Copy link

Hi Anton..
Is this part of the code between lines 1034/1042 necessary, or did you forget to remove it?

Click here

; IDE Options = PureBasic 5.70 LTS (Windows - x64)
; CursorPosition = 795
; FirstLine = 976
; Folding = --
; EnableThread
; EnableXP
; UseIcon = D:\games\Minecraft\1.ico
; Executable = D:\games\Minecraft\VLauncher-1.1.13.exe

@g5-freemen
Copy link
Author

g5-freemen commented Jan 5, 2021

Hi Anton..
Is this part of the code between lines 1034/1042 necessary, or did you forget to remove it?

Click here

Forget to remove :)
this is not mine code, this is work of compiler ))

Can you remove it or better to do it by myself ?

@ViNi-Arco
Copy link

Forget to remove :)
this is not mine code, this is work of compiler ))
Can you remove it or better to do it by myself ?

I cannot remove these lines :/
I think only you are allowed to avoid them.

Comment on lines 1034 to 1042

; IDE Options = PureBasic 5.70 LTS (Windows - x64)
; CursorPosition = 795
; FirstLine = 976
; Folding = --
; EnableThread
; EnableXP
; UseIcon = D:\games\Minecraft\1.ico
; Executable = D:\games\Minecraft\VLauncher-1.1.13.exe

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove them?

;) yes of course. Done.

@g5-freemen
Copy link
Author

cleanup some trash from code

@ghost
Copy link

ghost commented Feb 16, 2021

this is out of context, but if this launcher adds login for premium accounts as optional i'll uninstall all the other launchers

@ghost
Copy link

ghost commented Feb 26, 2021

Bug: 1.5.2 version isn't working, it crashes NULL. or something like that
https://pastebin.com/BAjm39rX
Only download 1.5.2 version, start it and u will have the crash screen

@Eric-01
Copy link

Eric-01 commented May 1, 2021

@g5-freemen Do you think this feature is really needed? Navigating to the Minecraft installation directory and then deleting a few directories manually is not difficult and doesn't take too much time.

Don't get me wrong, but if you have programming skills in PureBasic, I think that there are more important things to commit ;)

@g5-freemen
Copy link
Author

g5-freemen commented May 3, 2021

@g5-freemen Do you think this feature is really needed? Navigating to the Minecraft installation directory and then deleting a few directories manually is not difficult and doesn't take too much time.

Don't get me wrong, but if you have programming skills in PureBasic, I think that there are more important things to commit ;)

Better to do it easier way i think. I update Minecraft as soon as possible for my son and don't want to manually search and delete old versions.

p.S. i haven't any expirience with PureBasic (only with QBasic/QuickBasic many years ago), but it wasn't too difficult to add delete button. I'm not programmer, i'm mining master - sand, gravel, crushed stone, excavators, trucks, wheel loaders, etc. --> it's my profession

@DrunkenHax0r
Copy link

Hi, everyone!
Sorry, I didn't find where to create issues, so I'm writing here.

It's hard to understand that I have the wrong version of java, because when I click the Play button, no message is displayed or only part of it.
When trying to run with jdk 13 no output at all.
When trying to run with jre 8: "Error: A JNI error has occurred, please check your installation and try again".
Meanwhile, in the console, you can see additional info: "Exception in thread "main" java.lang.UnsupportedClassVersionError: net/minecraft/client/main/Main has been compiled by a more recent version of the Java Runtime (class file version 60.0), this version of the Java Runtime only recognizes class file versions up to 52.0"

@Eric-01
Copy link

Eric-01 commented Jul 11, 2021

DrunkenHax0r, in the past there was a separate issues section/tab in the Vortex Launcher repository on GitHub, but then, unfortunately, it has been closed and hidden, and it is still the case these days. I would really like to see it reopened at some point. It would be nice to have it for gathering feedback from people. I don't have Vortex Launcher download statistics, but I'm sure it has grown in popularity over the years. A proof of this thesis may be the fact that Windows SmartScreen no longer warns of Vortex Launcher as an unrecognized application and thus potentially dangerous.

Anyway, I assume you are using the latest version of Vortex Launcher (currently 1.1.12). What version of Minecraft are you trying to launch? Have you tried with the latest ones, i.e. Minecraft 1.17 and Java 16? If you are not sure where you should download Java from, a lot of people recommend OpenJDK from the AdoptOpenJDK project (which will soon operate as Adoptium BTW).

@DrunkenHax0r
Copy link

@Eric-01
Thank you for the information.
I corrected the output of java's error messages in my fork.

@Eric-01
Copy link

Eric-01 commented Jul 20, 2021

DrunkenHax0r, you can and probably should open a separate pull request then.

@Kotsasmin
Copy link

Uhmmm, does anyone know a Minecraft launcher with fullLaunchString and Minecraft downloader (libraries, versions and soon) coded in batch??? You know, the same launcher (Vortex) but coded in batch (no Bash)...

@NEOLabs-software
Copy link

there is, one coded in java
tlauncher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants