optional secondary header #12
Conversation
|
Took a brief look while mobile and looks good! Will look at it in some more detail when I get a chance to run it. Maybe this is my relative inexperience with rust, but do you always need to specify the value of the S generic even if you dont need to parse the secondary header? Also, this is one part I had trouble with when i tried to add something like this way back when: the CCSDS spec allows either a payload, or a secondary header, or a secondary header and a payload. Is it going to be easy to allow the payload to also be optional, but in a way thay both cannot be none at the same time? Also ultimately it would be nice to have unit tests to demonstrate usage and validate that it works as intended. I can add those later though. Thanks so much for your contribution! |
|
Yeah, I'm just working on the tests to see how well it works. At the moment this only works if you specify a Secondary Header. Re optional payload: I think the payload vector can just be left empty if no payload is expected |
|
Oh also, i noticed theres a |
No worries, in that case my plan was to just have a Premade empty header struct that people can pass in if they have no secondary header. Or maybe an overloaded method that does that for you (if rust supports that). |
It's needed for the lifetime parameter. Otherwise the compiler complains that it is not used.
From my experience it doesn't, haven't really tried it with functions, but for structs etc it doesn't allow that |
|
Overloading is possible with macros though. Not sure if we can achieve 100% what you're imagining |
|
Nah, overloading was just an idea. No big deal if its not possible with functions |
|
Well i totally forgot about this. You mentioned you were working on tests. Do you have any unit test cases to help demo the functionality? |
One option to do optional secondary header,
alternatively maybe a macro?