New context menu automation items #7317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rossmaxx
reviewed
Jun 13, 2024
Rossmaxx
reviewed
Jun 13, 2024
|
There's lots more nesting going on. I am a bit tired to nitpick everything |
Feel free to nitpick. I'm open to learn new things. |
Rossmaxx
reviewed
Jun 13, 2024
Rossmaxx
reviewed
Jun 13, 2024
Rossmaxx
reviewed
Jun 13, 2024
Rossmaxx
reviewed
Jun 13, 2024
Rossmaxx
reviewed
Jun 13, 2024
messmerd
reviewed
Jun 13, 2024
Veratil
requested changes
Jun 13, 2024
Because I pushed the changes right before when you completed your review. |
Rossmaxx
reviewed
Jun 20, 2024
| { | ||
| // getting nearest node | ||
| // in the clip that starts before this | ||
| for (auto it = clipBefore->getTimeMap().begin(); it != clipBefore->getTimeMap().end(); ++it) |
There was a problem hiding this comment.
This loop can not be replaced, because it would be a pointer to a typename Tnode instead of a key.
Qt provides a key() function that finds a key for a given T, but that is not optimized.
Qt documentation:
This function can be slow linear time, because QMap's internal data structure is optimized for fast lookup by key, not by value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3112
This PR adds new context menu options for
automatableModelsto improve the automation workflow.These options are the following:
In my view these options will make the automation system faster to use.