S3 render upload #64
Draft
S3 render upload #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely something I'd want, although not sure about S3. I already have code in my local instance that uploads videos above 8 MB to a local file server but never pushed it since it's too specific. I'd like a more general approach, maybe the option to put a custom command the output video path is passed into into so you can define your own upload target via curl, jq and what not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use a S3-compatible bucket host for uploading rendered videos instead of relying on Discord for hosting the videos. This allows circumventing the rather restrictive 8MB file size limit.
The code isn't particularly clean, and it's missing some error handling in case of upload failures. This draft mainly serves as a way of getting feedback on the overall idea.