Skip to content

Commit

Permalink
fix(llm/lld): Fixes the default analytics set to false when the analy…
Browse files Browse the repository at this point in the history
…tics opt in prompt feature flags are enabled
  • Loading branch information
cgrellard-ledger committed Jun 10, 2024
1 parent 9edad05 commit 1417c65
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .changeset/honest-balloons-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"ledger-live-desktop": patch
"live-mobile": patch
---

LLM / LLD - Fix overriding the analytics opt in when the analyticsOptInPrompt is only enabled for the Onboarding
7 changes: 6 additions & 1 deletion apps/ledger-live-desktop/src/renderer/Default.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,12 @@ export default function Default() {
const dispatch = useDispatch();

useEffect(() => {
if (!isLocked && analyticsFF?.enabled && !hasSeenAnalyticsOptInPrompt) {
if (
!isLocked &&
analyticsFF?.enabled &&
(!hasCompletedOnboarding || analyticsFF?.params?.entryPoints.includes("Portfolio")) &&
!hasSeenAnalyticsOptInPrompt
) {
dispatch(setShareAnalytics(false));
dispatch(setSharePersonalizedRecommendations(false));
}
Expand Down
17 changes: 15 additions & 2 deletions apps/ledger-live-mobile/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
exportSelector as settingsExportSelector,
osThemeSelector,
hasSeenAnalyticsOptInPromptSelector,
hasCompletedOnboardingSelector,
} from "~/reducers/settings";
import { accountsSelector, exportSelector as accountsExportSelector } from "~/reducers/accounts";
import { exportSelector as bleSelector } from "~/reducers/ble";
Expand Down Expand Up @@ -105,13 +106,25 @@ function App() {
const accounts = useSelector(accountsSelector);
const analyticsFF = useFeature("llmAnalyticsOptInPrompt");
const hasSeenAnalyticsOptInPrompt = useSelector(hasSeenAnalyticsOptInPromptSelector);
const hasCompletedOnboarding = useSelector(hasCompletedOnboardingSelector);
const dispatch = useDispatch();

useEffect(() => {
if (!analyticsFF?.enabled || hasSeenAnalyticsOptInPrompt) return;
if (
!analyticsFF?.enabled ||
(hasCompletedOnboarding && !analyticsFF?.params?.entryPoints.includes("Portfolio")) ||
hasSeenAnalyticsOptInPrompt
)
return;
dispatch(setAnalytics(false));
dispatch(setPersonalizedRecommendations(false));
}, [analyticsFF?.enabled, dispatch, hasSeenAnalyticsOptInPrompt]);
}, [
analyticsFF?.enabled,
analyticsFF?.params?.entryPoints,
dispatch,
hasSeenAnalyticsOptInPrompt,
hasCompletedOnboarding,
]);

useAccountsWithFundsListener(accounts, updateIdentify);
useAppStateListener();
Expand Down

0 comments on commit 1417c65

Please sign in to comment.