fix: react ui theme spacing for Button component

LedgerHQ · May 21, 2024 · 19a4509 · 19a4509
1 parent eadfbb2
commit 19a4509
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/.changeset/old-carrots-complain.md b/.changeset/old-carrots-complain.md
@@ -0,0 +1,6 @@
+---
+"ledger-live-desktop": minor
+"@ledgerhq/react-ui": minor
+---
+
+Fix border-radius in our react DS for the Button
diff --git a/apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx b/apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx
@@ -5,8 +5,6 @@ import { useTrack } from "~/renderer/analytics/segment";
 import styled from "styled-components";
 
 export const Base = styled(BaseButton)<{ big?: boolean }>`
-  border-radius: 44px;
-
   font-size: ${p => (p.big ? "14px" : "12px")};
   height: 40px;
   line-height: 40px;

diff --git a/apps/ledger-live-desktop/src/renderer/screens/market/index.tsx b/apps/ledger-live-desktop/src/renderer/screens/market/index.tsx
@@ -24,8 +24,6 @@ const SearchContainer = styled(Flex).attrs({ flexShrink: "1" })`
 `;
 
 export const Button = styled(BaseButton)<{ big?: boolean }>`
-  border-radius: 44px;
-
   ${p =>
     p.Icon
       ? `

diff --git a/libs/ui/packages/react/src/components/cta/Button/index.tsx b/libs/ui/packages/react/src/components/cta/Button/index.tsx
@@ -162,7 +162,7 @@ export const Base = baseStyled.button.attrs((p: BaseProps) => ({
 }))<BaseProps>`
   background-color: transparent;
   border-color: transparent;
-  border-radius: ${p => p.theme.space[13]}px;
+  border-radius: 44px;
   border-style: solid;
   border-width: ${p => (p.outline || p.variant === "shade" ? 1 : 0)}px;
   font-weight: 600;