Merge pull request #6817 from LedgerHQ/fix/analytics_ff_dev

fix(llm/ldd): fix analytics problem

.changeset/breezy-coins-talk.md

@@ -0,0 +1,6 @@
+---
+"ledger-live-desktop": patch
+"live-mobile": patch
+---
+
+Fix analytics problem that made all analytics disabled by default

apps/ledger-live-desktop/src/renderer/Default.tsx

@@ -2,7 +2,7 @@ import React, { useEffect, lazy, Suspense } from "react";
 import styled from "styled-components";
 import { ipcRenderer } from "electron";
 import { Redirect, Route, Switch, useHistory, useLocation } from "react-router-dom";
-import { useSelector } from "react-redux";
+import { useDispatch, useSelector } from "react-redux";
 import TrackAppStart from "~/renderer/components/TrackAppStart";
 import { LiveApp } from "~/renderer/screens/platform";
 import { BridgeSyncProvider } from "~/renderer/bridge/BridgeSyncContext";
@@ -48,8 +48,12 @@ import { Flex, InfiniteLoader } from "@ledgerhq/react-ui";
 import useAccountsWithFundsListener from "@ledgerhq/live-common/hooks/useAccountsWithFundsListener";
 import { accountsSelector } from "./reducers/accounts";
 import { useRecoverRestoreOnboarding } from "~/renderer/hooks/useRecoverRestoreOnboarding";
-import { hasCompletedOnboardingSelector } from "~/renderer/reducers/settings";
+import {
+  hasCompletedOnboardingSelector,
+  hasSeenAnalyticsOptInPromptSelector,
+} from "~/renderer/reducers/settings";
 import { useAutoDismissPostOnboardingEntryPoint } from "@ledgerhq/live-common/postOnboarding/hooks/index";
+import { setShareAnalytics, setSharePersonalizedRecommendations } from "./actions/settings";
 
 const PlatformCatalog = lazy(() => import("~/renderer/screens/platform"));
 const Dashboard = lazy(() => import("~/renderer/screens/dashboard"));
@@ -194,6 +198,15 @@ export default function Default() {
   useAutoDismissPostOnboardingEntryPoint();
 
   const listAppsV2 = useFeature("listAppsV2minor1");
+  const analyticsFF = useFeature("lldAnalyticsOptInPrompt");
+  const hasSeenAnalyticsOptInPrompt = useSelector(hasSeenAnalyticsOptInPromptSelector);
+  const dispatch = useDispatch();
+
+  useEffect(() => {
+    if (!analyticsFF?.enabled || hasSeenAnalyticsOptInPrompt) return;
+    dispatch(setShareAnalytics(false));
+    dispatch(setSharePersonalizedRecommendations(false));
+  });
 
   useEffect(() => {
     if (!listAppsV2) return;

apps/ledger-live-desktop/src/renderer/reducers/settings.ts

@@ -150,8 +150,8 @@ const INITIAL_STATE: SettingsState = {
   pairExchanges: {},
   developerMode: !!process.env.__DEV__,
   loaded: false,
-  shareAnalytics: false,
-  sharePersonalizedRecommandations: false,
+  shareAnalytics: true,
+  sharePersonalizedRecommandations: true,
   hasSeenAnalyticsOptInPrompt: false,
   sentryLogs: true,
   lastUsedVersion: __APP_VERSION__,

apps/ledger-live-mobile/src/index.tsx

@@ -28,7 +28,11 @@ import {
   saveCountervalues,
   savePostOnboardingState,
 } from "./db";
-import { exportSelector as settingsExportSelector, osThemeSelector } from "~/reducers/settings";
+import {
+  exportSelector as settingsExportSelector,
+  osThemeSelector,
+  hasSeenAnalyticsOptInPromptSelector,
+} from "~/reducers/settings";
 import { accountsSelector, exportSelector as accountsExportSelector } from "~/reducers/accounts";
 import { exportSelector as bleSelector } from "~/reducers/ble";
 import LocaleProvider, { i18n } from "~/context/Locale";
@@ -65,15 +69,15 @@ import { useListenToHidDevices } from "~/hooks/useListenToHidDevices";
 import { DeeplinksProvider } from "~/navigation/DeeplinksProvider";
 import StyleProvider from "./StyleProvider";
 import { performanceReportSubject } from "~/components/PerformanceConsole/usePerformanceReportsLog";
-import { setOsTheme } from "~/actions/settings";
+import { setAnalytics, setOsTheme, setPersonalizedRecommendations } from "~/actions/settings";
 import TransactionsAlerts from "~/components/TransactionsAlerts";
 import {
   useFetchCurrencyAll,
   useFetchCurrencyFrom,
 } from "@ledgerhq/live-common/exchange/swap/hooks/index";
 import useAccountsWithFundsListener from "@ledgerhq/live-common/hooks/useAccountsWithFundsListener";
 import { updateIdentify } from "./analytics";
-import { getFeature } from "@ledgerhq/live-common/featureFlags/index";
+import { getFeature, useFeature } from "@ledgerhq/live-common/featureFlags/index";
 import { StorylyProvider } from "./components/StorylyStories/StorylyProvider";
 import { useSettings } from "~/hooks";
 import AppProviders from "./AppProviders";
@@ -98,6 +102,15 @@ const styles = StyleSheet.create({
 
 function App() {
   const accounts = useSelector(accountsSelector);
+  const analyticsFF = useFeature("llmAnalyticsOptInPrompt");
+  const hasSeenAnalyticsOptInPrompt = useSelector(hasSeenAnalyticsOptInPromptSelector);
+  const dispatch = useDispatch();
+
+  useEffect(() => {
+    if (!analyticsFF?.enabled || hasSeenAnalyticsOptInPrompt) return;
+    dispatch(setAnalytics(false));
+    dispatch(setPersonalizedRecommendations(false));
+  }, [analyticsFF?.enabled, dispatch, hasSeenAnalyticsOptInPrompt]);
 
   useAccountsWithFundsListener(accounts, updateIdentify);
   useAppStateListener();

apps/ledger-live-mobile/src/reducers/settings.ts

@@ -101,8 +101,8 @@ export const INITIAL_STATE: SettingsState = {
   counterValueExchange: null,
   privacy: null,
   reportErrorsEnabled: true,
-  analyticsEnabled: false,
-  personalizedRecommendationsEnabled: false,
+  analyticsEnabled: true,
+  personalizedRecommendationsEnabled: true,
   currenciesSettings: {},
   pairExchanges: {},
   selectedTimeRange: "month",