Merge pull request #1812 from LedgerHQ/bugfix/change-push-notifs-feat…

…ure-flag-key The push notifications feature flag's key has been modified
LedgerHQ · Nov 15, 2022 · 1dc29a7 · 1dc29a7
1 parent 70efc42
commit 1dc29a7
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 7 deletions.
diff --git a/.changeset/weak-days-end.md b/.changeset/weak-days-end.md
@@ -0,0 +1,6 @@
+---
+"live-mobile": patch
+"@ledgerhq/types-live": patch
+---
+
+The push notifications feature flag's key has been modified
diff --git a/apps/ledger-live-mobile/src/logic/notifications.tsx b/apps/ledger-live-mobile/src/logic/notifications.tsx
@@ -75,7 +75,7 @@ const getIsNotifEnabled = async () => {
 };
 
 const useNotifications = () => {
-  const pushNotificationsFeature = useFeature("pushNotifications");
+  const pushNotificationsFeature = useFeature("brazePushNotifications");
 
   const isPushNotificationsModalOpen = useSelector(
     notificationsModalOpenSelector,

diff --git a/apps/ledger-live-mobile/src/screens/Modals/index.tsx b/apps/ledger-live-mobile/src/screens/Modals/index.tsx
@@ -25,7 +25,7 @@ const getCurrentRouteName = (
 const Modals = () => {
   const navigation = useNavigation();
 
-  const pushNotificationsFeature = useFeature("pushNotifications");
+  const pushNotificationsFeature = useFeature("brazePushNotifications");
   const { onPushNotificationsRouteChange } = useNotifications();
 
   const ratingsFeature = useFeature("ratings");
@@ -73,7 +73,7 @@ const Modals = () => {
 
   return (
     <>
-      <FeatureToggle feature="pushNotifications">
+      <FeatureToggle feature="brazePushNotifications">
         <PushNotificationsModal />
       </FeatureToggle>
       <FeatureToggle feature="ratings">

diff --git a/apps/ledger-live-mobile/src/screens/Settings/index.tsx b/apps/ledger-live-mobile/src/screens/Settings/index.tsx
@@ -76,7 +76,7 @@ export default function Settings({
         onClick={() => navigation.navigate(ScreenName.AboutSettings)}
         arrowRight
       />
-      <FeatureToggle feature="pushNotifications">
+      <FeatureToggle feature="brazePushNotifications">
         <SettingsCard
           title={t("settings.notifications.title")}
           desc={t("settings.notifications.desc")}

diff --git a/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts b/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts
@@ -4,7 +4,7 @@ export const defaultFeatures: DefaultFeatures = {
   learn: {
     enabled: false,
   },
-  pushNotifications: {
+  brazePushNotifications: {
     enabled: false,
   },
   deviceLocalization: {

diff --git a/libs/ledgerjs/packages/types-live/README.md b/libs/ledgerjs/packages/types-live/README.md
@@ -491,7 +491,7 @@ Type: [string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Globa
 
 Add others with union (e.g. "learn" | "market" | "foo")
 
-Type: (`"learn"` | `"pushNotifications"` | `"llmNewDeviceSelection"` | `"llmUsbFirmwareUpdate"` | `"ratings"` | `"counterValue"` | `"deviceLocalization"` | `"deviceInitialApps"` | `"buyDeviceFromLive"` | `"ptxSmartRouting"` | `"currencyOsmosis"` | `"currencyOsmosisMobile"` | `"currencyFantom"` | `"currencyMoonbeam"` | `"currencyCronos"` | `"currencySongbird"` | `"currencyFlare"` | `"currencyFantomMobile"` | `"currencyMoonbeamMobile"` | `"currencyCronosMobile"` | `"currencySongbirdMobile"` | `"currencyFlareMobile"` | `"ptxSmartRoutingMobile"` | `"mockFeature"` | `"syncOnboarding"` | `"walletConnectLiveApp"` | `"customImage"` | `"referralProgramDiscoverCard"` | `"referralProgramDesktopBanner"` | `"disableNftSend"` | `"disableNftLedgerMarket"` | `"disableNftRaribleOpensea"` | `"receiveStakingFlowConfigDesktop"` | `"ethStakingProviders"`)
+Type: (`"learn"` | `"brazePushNotifications"` | `"llmNewDeviceSelection"` | `"llmUsbFirmwareUpdate"` | `"ratings"` | `"counterValue"` | `"deviceLocalization"` | `"deviceInitialApps"` | `"buyDeviceFromLive"` | `"ptxSmartRouting"` | `"currencyOsmosis"` | `"currencyOsmosisMobile"` | `"currencyFantom"` | `"currencyMoonbeam"` | `"currencyCronos"` | `"currencySongbird"` | `"currencyFlare"` | `"currencyFantomMobile"` | `"currencyMoonbeamMobile"` | `"currencyCronosMobile"` | `"currencySongbirdMobile"` | `"currencyFlareMobile"` | `"ptxSmartRoutingMobile"` | `"mockFeature"` | `"syncOnboarding"` | `"walletConnectLiveApp"` | `"customImage"` | `"referralProgramDiscoverCard"` | `"referralProgramDesktopBanner"` | `"disableNftSend"` | `"disableNftLedgerMarket"` | `"disableNftRaribleOpensea"` | `"receiveStakingFlowConfigDesktop"` | `"ethStakingProviders"`)
 
 ### Feature
 

diff --git a/libs/ledgerjs/packages/types-live/src/feature.ts b/libs/ledgerjs/packages/types-live/src/feature.ts
@@ -1,7 +1,7 @@
 /**  Add others with union (e.g. "learn" | "market" | "foo") */
 export type FeatureId =
   | "learn"
-  | "pushNotifications"
+  | "brazePushNotifications"
   | "llmNewDeviceSelection"
   | "llmUsbFirmwareUpdate"
   | "ratings"