bugfix(Storage): Wrong message when LNX storage is full

LedgerHQ · Sep 20, 2022 · d3be887 · d3be887
1 parent badf7fb
commit d3be887
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 13 deletions.
diff --git a/.changeset/rich-snakes-turn.md b/.changeset/rich-snakes-turn.md
@@ -0,0 +1,5 @@
+---
+"live-mobile": patch
+---
+
+Wrong message when LNX storage is full
diff --git a/apps/ledger-live-mobile/src/locales/en/common.json b/apps/ledger-live-mobile/src/locales/en/common.json
@@ -1071,7 +1071,7 @@
     },
     "stepLanguage": {
       "title": "Select your language",
-      "cta": "Continue", 
+      "cta": "Continue",
       "changeDeviceLanguage": "{{language}} is also available for your {{deviceName}}",
       "changeDeviceLanguageDescription": "Would you like to change its language to {{language}}?",
       "warning": {
@@ -3352,6 +3352,7 @@
       "appsInstalled": "<0>{{number}}</0> app",
       "appsInstalled_plural": "<0>{{number}}</0> apps",
       "storageAvailable": "available",
+      "noFreeSpace": "No storage left",
       "appsToUpdate": "<0>{{number}}</0> update",
       "appsToUpdate_plural": "<0>{{number}}</0> updates"
     },

diff --git a/apps/ledger-live-mobile/src/screens/Manager/Device/DeviceAppStorage.tsx b/apps/ledger-live-mobile/src/screens/Manager/Device/DeviceAppStorage.tsx
@@ -49,6 +49,8 @@ const DeviceAppStorage = ({
     [apps, appsSpaceBytes],
   );
 
+  const isDeviceFull = !freeSpaceBytes;
+
   return (
     /* Fixme: Storage info line might be too tight with some translation, consider putting it on multiple lines */
     <Box mx={6}>
@@ -106,24 +108,35 @@ const DeviceAppStorage = ({
             </Trans>
           </Text>
         </Flex>
+
         <Flex flexDirection={"row"} alignItems={"center"}>
           {shouldWarnMemory && (
             <Box mr={2}>
               <WarningMedium color={"palette.warning.c60"} size={14} />
             </Box>
           )}
-          <Text
-            variant={"small"}
-            fontWeight={"medium"}
-            color={"palette.neutral.c80"}
-          >
-            <ByteSize
-              value={freeSpaceBytes}
-              deviceModel={deviceModel}
-              firmwareVersion={deviceInfo.version}
-            />{" "}
-            <Trans i18nKey="manager.storage.storageAvailable" />
-          </Text>
+          {isDeviceFull ? (
+            <Text
+              variant={"small"}
+              fontWeight={"medium"}
+              color={"palette.warning.c60"}
+            >
+              <Trans i18nKey="manager.storage.noFreeSpace" />
+            </Text>
+          ) : (
+            <Text
+              variant={"small"}
+              fontWeight={"medium"}
+              color={"palette.neutral.c80"}
+            >
+              <ByteSize
+                value={freeSpaceBytes}
+                deviceModel={deviceModel}
+                firmwareVersion={deviceInfo.version}
+              />{" "}
+              <Trans i18nKey="manager.storage.storageAvailable" />
+            </Text>
+          )}
         </Flex>
       </Flex>
       <StorageRepartition