Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LIVE-3127): Add cosmos account banner #1017

Merged
merged 8 commits into from
Aug 31, 2022

Conversation

sarneijim
Copy link
Contributor

πŸ“ Description

Add cosmos account banner
3 modes:

  • Delegate
  • Redelegate
  • Hidden

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot 2022-08-19 at 13 58 56

πŸš€ Expectations to reach

Scope:

  • Basic util in common
  • Implementation in Desktop
  • Implementation in Mobile

@sarneijim sarneijim added desktop Has changes in LLD mobile Has changes in LLM labels Aug 22, 2022
@vercel
Copy link

vercel bot commented Aug 22, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Aug 31, 2022 at 8:35AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 31, 2022 at 8:35AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Aug 31, 2022 at 8:35AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Aug 31, 2022 at 8:35AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

πŸ¦‹ Changeset detected

Latest commit: a501ca8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
live-mobile Minor
ledger-live-desktop Minor
@ledgerhq/live-common Minor
@ledgerhq/live-cli Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Aug 22, 2022

@sarneijim

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1017 (a501ca8) into develop (3f754a2) will decrease coverage by 3.73%.
The diff coverage is 97.56%.

@@             Coverage Diff             @@
##           develop    #1017      +/-   ##
===========================================
- Coverage    47.49%   43.76%   -3.74%     
===========================================
  Files          640      588      -52     
  Lines        28682    24933    -3749     
  Branches      7389     6722     -667     
===========================================
- Hits         13623    10912    -2711     
+ Misses       15001    13969    -1032     
+ Partials        58       52       -6     
Flag Coverage Ξ”
test 43.76% <97.56%> (-3.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...s/ledger-live-common/src/families/cosmos/banner.ts 97.56% <97.56%> (ΓΈ)
...dger-live-common/src/currencies/sortByMarketcap.ts 86.00% <0.00%> (-4.33%) ⬇️
libs/ledger-live-common/src/manager/index.ts 35.35% <0.00%> (-2.29%) ⬇️
libs/ledger-live-common/src/api/Manager.ts 38.01% <0.00%> (-1.87%) ⬇️
...bs/ledger-live-common/src/account/serialization.ts 53.28% <0.00%> (-1.41%) ⬇️
libs/ledger-live-common/src/hw/getVersion.ts 98.63% <0.00%> (-1.37%) ⬇️
libs/ledger-live-common/src/reconciliation.ts 31.53% <0.00%> (-1.18%) ⬇️
libs/ledger-live-common/src/errors.ts 100.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/hw/getDeviceInfo.ts 82.97% <0.00%> (ΓΈ)
...s/ledgerjs/packages/cryptoassets/src/currencies.ts 100.00% <0.00%> (ΓΈ)
... and 81 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarneijim you need to add changesets for the changes you've made. You can find the documentation on the tool right here. https://github.com/LedgerHQ/ledger-live/wiki/Changesets

Don't hesitate to ping me if you have any questions

@sarneijim
Copy link
Contributor Author

@sarneijim you need to add changesets for the changes you've made. You can find the documentation on the tool right here. https://github.com/LedgerHQ/ledger-live/wiki/Changesets

Don't hesitate to ping me if you have any questions

Done. I assume as it is not a breaking change is a minor change for the 3 packages. :)

.changeset/new-doors-flow.md Outdated Show resolved Hide resolved
@valpinkman
Copy link
Member

@sarneijim you need to add changesets for the changes you've made. You can find the documentation on the tool right here. https://github.com/LedgerHQ/ledger-live/wiki/Changesets
Don't hesitate to ping me if you have any questions

Done. I assume as it is not a breaking change is a minor change for the 3 packages. :)

yes you are right it's suppose to me minor (yet you've used patch i think)

@sarneijim sarneijim force-pushed the feat/LIVE-3127-add-cosmos-banner branch from bc7b8f5 to af4516b Compare August 30, 2022 13:24
.changeset/quiet-singers-beg.md Outdated Show resolved Hide resolved
.changeset/small-donkeys-hope.md Outdated Show resolved Hide resolved
.changeset/tough-geckos-reflect.md Outdated Show resolved Hide resolved
@sarneijim sarneijim force-pushed the feat/LIVE-3127-add-cosmos-banner branch from 7bb13bd to 21ed0bd Compare August 31, 2022 08:21
@ghost ghost added the feature ready label Aug 31, 2022
@ghost ghost changed the base branch from develop to release August 31, 2022 10:51
@hzheng-ledger hzheng-ledger merged commit 9c655cd into release Aug 31, 2022
@hzheng-ledger hzheng-ledger deleted the feat/LIVE-3127-add-cosmos-banner branch August 31, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD feature ready mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants