-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LIVE-3127): Add cosmos account banner #1017
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: a501ca8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
6810b1c
to
0d8d568
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1017 +/- ##
===========================================
- Coverage 47.49% 43.76% -3.74%
===========================================
Files 640 588 -52
Lines 28682 24933 -3749
Branches 7389 6722 -667
===========================================
- Hits 13623 10912 -2711
+ Misses 15001 13969 -1032
+ Partials 58 52 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d2d95b0
to
2562120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
apps/ledger-live-desktop/src/renderer/families/cosmos/utils.jsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/families/cosmos/utils.jsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/families/cosmos/RedelegationFlowModal/Body.jsx
Show resolved
Hide resolved
a464b06
to
5b47c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarneijim you need to add changesets for the changes you've made. You can find the documentation on the tool right here. https://github.com/LedgerHQ/ledger-live/wiki/Changesets
Don't hesitate to ping me if you have any questions
Done. I assume as it is not a breaking change is a minor change for the 3 packages. :) |
yes you are right it's suppose to me minor (yet you've used patch i think) |
bc7b8f5
to
af4516b
Compare
apps/ledger-live-desktop/src/renderer/screens/account/index.jsx
Outdated
Show resolved
Hide resolved
7bb13bd
to
21ed0bd
Compare
π Description
Add cosmos account banner
3 modes:
β Context
β Checklist
πΈ Demo
π Expectations to reach
Scope: