LIVE-2641 Prevent emitting an event when device descriptor is null

[grsoares21]

📝 Description

This is a fix for an error that was found in Sentry.
While scanning devices, if there was a device for which the scan failed, we emitted is as a null device. However this broke on React end since we were trying to access infos from this null value as if it were an object.
See associated JIRA task for more info on the error.

The PR prevents the emission of an event in this case, fixing the issue directly in the scanning logic. This could have been prevented if we had a stricter typing, so I've also added some typing to the logic.

❓ Context

• Impacted projects: ledgerjs/react-native-hw-transport-ble, ledger-live-mobile
• Linked resource(s): LIVE-2641

✅ Checklist

• [N/A] Test coverage -- this was more a question of proper typing rather than tests
• Atomic delivery
• No breaking changes

📸 Demo

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Aug 29, 2022 at 1:35PM (UTC)

3 Ignored Deployments

Name	Status	Preview	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)		Aug 29, 2022 at 1:35PM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)		Aug 29, 2022 at 1:35PM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)		Aug 29, 2022 at 1:35PM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: e9f0cc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
live-mobile	Patch
@ledgerhq/react-native-hw-transport-ble	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

@grsoares21

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

[gre]

lint issues (according to CI)

[codecov]

Codecov Report

Merging #1070 (6c9bef8) into develop (9dff5cb) will decrease coverage by 47.57%.
The diff coverage is n/a.

❗ Current head 6c9bef8 differs from pull request most recent head e9f0cc6. Consider uploading reports for the commit e9f0cc6 to get more accurate results

@@             Coverage Diff             @@
##           develop   #1070       +/-   ##
===========================================
- Coverage    47.57%       0   -47.58%     
===========================================
  Files          647       0      -647     
  Lines        28899       0    -28899     
  Branches      7456       0     -7456     
===========================================
- Hits         13750       0    -13750     
+ Misses       15091       0    -15091     
+ Partials        58       0       -58     

Flag	Coverage Δ
test	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/ledger-live-common/src/account/importAccounts.ts
libs/ledger-live-common/src/range.ts
...ive-common/src/families/ethereum/hw-signMessage.ts
...edger-live-common/src/exchange/swap/hooks/index.ts
libs/ledger-live-common/src/countervalues/mock.ts
...js/packages/hw-app-btc/src/newops/psbtFinalizer.ts
...edger-live-common/src/transaction/signOperation.ts
...bs/ledgerjs/packages/hw-app-btc/src/signMessage.ts
...er-live-common/src/currencies/CurrencyURIScheme.ts
...on/src/families/osmosis/deviceTransactionConfig.ts
... and 637 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.