-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: FAT-43-100: new BLE pairing flow #1097
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a98f1dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
6167b7d
to
4e30c37
Compare
4e30c37
to
0a7f2d9
Compare
Codecov Report
@@ Coverage Diff @@
## release #1097 +/- ##
===========================================
+ Coverage 48.00% 48.01% +0.01%
===========================================
Files 674 674
Lines 30016 30022 +6
Branches 7813 7815 +2
===========================================
+ Hits 14410 14416 +6
Misses 15547 15547
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still haven't finished the review, will continue later
apps/ledger-live-mobile/src/components/DeviceAction/getDeviceAnimation.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/BleDevicePairing.tsx
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/BleDeviceScanning.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/BleDevicePairingFlow/BleDeviceScanning.tsx
Outdated
Show resolved
Hide resolved
731ccf9
to
854d0ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice PR
4d89f63
to
04b17cd
Compare
04b17cd
to
53c67f5
Compare
* chore: generate changeset * update screenshots (ubuntu-latest) * update screenshots (windows-latest) * update screenshots (macos-latest) * fix(screenshots): make send modal wait for button to stop loading * update screenshots (ubuntu-latest) * update screenshots (windows-latest) * update screenshots (macos-latest) * chore: trigger CI Co-authored-by: Team Live <[email protected]>
- consistent prop name filterByDeviceModelIds - filter out devices by device ids during BLE scanning
- new ble pairing flow accessible from the debug menu - scanning filtering on device models and on already known devices - option to add paired device to known devices list
53c67f5
to
a98f1dd
Compare
📝 Description
Not yet user-facing. Only available from the debug menu.
Features:
Why adding the newly paired device info in the route params, and not adding a new
pairedDevice
in the redux store ?pairedDevice
, and don't want to create a complex logic to do it.❓ Context
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.