Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ LIVE-3509 - LLM Deeplinks updated for buy/sell live apps flow #1105

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Aug 30, 2022

📝 Description

Update LLM Deeplnks for Buy / Sell Live app flows to take in account currency as a param

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3509

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 11:48AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 6, 2022 at 11:48AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2022 at 11:48AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2022 at 11:48AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: 8186d2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1105 (47134c1) into develop (9dff5cb) will decrease coverage by 4.44%.
The diff coverage is 55.95%.

❗ Current head 47134c1 differs from pull request most recent head fd59e3d. Consider uploading reports for the commit fd59e3d to get more accurate results

@@             Coverage Diff             @@
##           develop    #1105      +/-   ##
===========================================
- Coverage    47.57%   43.13%   -4.45%     
===========================================
  Files          647      572      -75     
  Lines        28899    24409    -4490     
  Branches      7456     6630     -826     
===========================================
- Hits         13750    10528    -3222     
+ Misses       15091    13836    -1255     
+ Partials        58       45      -13     
Flag Coverage Δ
test 43.13% <55.95%> (-4.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/hw/getDeviceInfo.ts 82.97% <ø> (ø)
libs/ledger-live-common/src/manager/index.ts 35.35% <0.00%> (-2.29%) ⬇️
libs/ledger-live-common/src/platform/tracking.ts 100.00% <ø> (ø)
libs/ledger-live-common/src/reconciliation.ts 31.53% <0.00%> (-1.18%) ⬇️
libs/ledger-live-common/src/api/Manager.ts 38.01% <21.42%> (-1.87%) ⬇️
libs/ledger-live-common/src/bot/formatters.ts 22.09% <25.00%> (-0.53%) ⬇️
...bs/ledger-live-common/src/account/serialization.ts 53.28% <33.33%> (-1.41%) ⬇️
...s/ledger-live-common/src/account/importAccounts.ts 70.88% <48.57%> (+54.55%) ⬆️
...dger-live-common/src/countervalues/modules/weth.ts 81.81% <66.66%> (+1.81%) ⬆️
libs/ledger-live-common/src/platform/logic.ts 71.73% <73.03%> (ø)
... and 91 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 30, 2022

@LFBarreto

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto force-pushed the feat/LIVE-3509-LLM-Deeplink-Buy-Sell-LiveApp branch from fd59e3d to 8186d2e Compare September 6, 2022 11:46
@LFBarreto LFBarreto merged commit 7b1959e into develop Sep 7, 2022
@LFBarreto LFBarreto deleted the feat/LIVE-3509-LLM-Deeplink-Buy-Sell-LiveApp branch September 7, 2022 09:47
@desirendr desirendr added this to the Ledger Live Mobile 3.8.x milestone Sep 8, 2022
@desirendr desirendr added translations Translation files have been touched and removed translations Translation files have been touched labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants