Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3446 LIVE-3452 LLM - fix analytics issue reborn #1136

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Sep 1, 2022

πŸ“ Description

Fix issues on analytics for reborn

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 1, 2022 at 1:12PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 1, 2022 at 1:12PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 1, 2022 at 1:12PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 1, 2022 at 1:12PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

πŸ¦‹ Changeset detected

Latest commit: d66472e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1136 (d60df3c) into develop (0f60c43) will increase coverage by 23.58%.
The diff coverage is n/a.

❗ Current head d60df3c differs from pull request most recent head d66472e. Consider uploading reports for the commit d66472e to get more accurate results

@@             Coverage Diff              @@
##           develop    #1136       +/-   ##
============================================
+ Coverage    47.84%   71.42%   +23.58%     
============================================
  Files          650       15      -635     
  Lines        29121      483    -28638     
  Branches      7532       80     -7452     
============================================
- Hits         13932      345    -13587     
+ Misses       15131      131    -15000     
+ Partials        58        7       -51     
Flag Coverage Ξ”
test 71.42% <ΓΈ> (+23.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...ive-common/src/families/cosmos/js-signOperation.ts
...r-live-common/src/families/elrond/serialization.ts
...-live-common/src/families/osmosis/api/sdk.types.ts
...ledger-live-common/src/families/bitcoin/bech32m.ts
...-live-common/src/families/tezos/synchronisation.ts
libs/ledger-live-common/src/crypto/index.ts
...common/src/families/crypto_org/js-signOperation.ts
.../src/families/bitcoin/wallet-btc/crypto/bitcoin.ts
libs/ledger-live-common/src/manager/provider.ts
...bs/ledger-live-common/src/families/cosmos/react.ts
... and 625 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

@LFBarreto

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit 268f547 into develop Sep 6, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-3446-analytics-reborn-issues branch September 6, 2022 12:06
@desirendr desirendr added this to the Ledger Live Mobile 3.8.x milestone Sep 8, 2022
@desirendr desirendr added translations Translation files have been touched and removed translations Translation files have been touched labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants