Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove onboarding v2 code #1196

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

pierrelouis-c
Copy link
Contributor

πŸ“ Description

This PR remove v2 onboarding

❓ Context

  • Impacted projects: ledger-live-desktop
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@pierrelouis-c pierrelouis-c requested a review from a team as a code owner September 6, 2022 13:16
@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 6, 2022 at 2:27PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 6, 2022 at 2:27PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2022 at 2:27PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2022 at 2:27PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2022

πŸ¦‹ Changeset detected

Latest commit: 3eb88f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1196 (3eb88f5) into develop (a9e2807) will decrease coverage by 28.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1196       +/-   ##
============================================
- Coverage    74.23%   46.22%   -28.01%     
============================================
  Files           59      618      +559     
  Lines         3862    27512    +23650     
  Branches       758     7246     +6488     
============================================
+ Hits          2867    12718     +9851     
- Misses         992    14744    +13752     
- Partials         3       50       +47     
Flag Coverage Ξ”
test 46.22% <ΓΈ> (-28.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/hw-app-eth/src/utils.ts
...ledgerjs/packages/hw-transport-mocker/src/index.ts
...hw-transport-mocker/src/createTransportRecorder.ts
...s/hw-transport-mocker/src/openTransportReplayer.ts
...js/packages/hw-app-eth/src/services/ledger/nfts.ts
...s/packages/hw-app-eth/src/services/ledger/index.ts
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts
...ckages/hw-app-eth/src/services/ledger/contracts.ts
...hw-transport-mocker/src/createTransportReplayer.ts
...js/packages/hw-app-eth/src/modules/EIP712/index.ts
... and 583 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

@pierrelouis-c

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

windows

Actual Diff Expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected
market-btc-buy-page-actual market-btc-buy-page-diff market-btc-buy-page-expected

@pierrelouis-c pierrelouis-c merged commit d9800ac into develop Sep 7, 2022
@pierrelouis-c pierrelouis-c deleted the support/remove-v2-onboarding-code branch September 7, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants