[LIVE-3146][LIVE-3626] Feature - EIP712 filtering

[lambertkevin]

📝 Description

This PR adds the filtering to the EIP712 clear signing. It requires the nano app 1.9.20-EIP712 Ethereum and clones apps to be tested.

❓ Context

• Impacted projects: ledgerjs/hw-app-eth, ledgerjs/live-common, ledger-live-desktop, ledger-live-mobile
• Linked resource(s):
• https://ledgerhq.atlassian.net/browse/LIVE-3146
• https://ledgerhq.atlassian.net/browse/LIVE-3626

✅ Checklist

• Test coverage
• Atomic delivery
• No breaking changes

📸 Demo

EIP712 with CAL example

Screen.Recording.2022-09-20.at.16.52.18.mov

RPReplay_Final1663771621.mov

EIP712 without CAL example

Screen.Recording.2022-09-20.at.16.56.19.mov

RPReplay_Final1663771523.MP4

EIP191

Screen.Recording.2022-09-20.at.16.57.33.mov

RPReplay_Final1663771707.MP4

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Nov 10, 2022 at 9:24AM (UTC)

3 Ignored Deployments

Name	Status	Preview	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)		Nov 10, 2022 at 9:24AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)		Nov 10, 2022 at 9:24AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)		Nov 10, 2022 at 9:24AM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: edb32aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@ledgerhq/live-common	Minor
ledger-live-desktop	Minor
@ledgerhq/hw-app-eth	Minor
live-mobile	Minor
@ledgerhq/cryptoassets	Minor
ledger-libs	Minor
@ledgerhq/live-cli	Patch
live-common-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

@lambertkevin

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

[codecov]

Codecov Report

Base: 70.84% // Head: 44.81% // Decreases project coverage by -26.03% ⚠️

Coverage data is based on head (edb32aa) compared to base (070f58e).
Patch coverage: 67.59% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #1211       +/-   ##
============================================
- Coverage    70.84%   44.81%   -26.04%     
============================================
  Files           46      637      +591     
  Lines         3070    26873    +23803     
  Branches       612     7315     +6703     
============================================
+ Hits          2175    12042     +9867     
- Misses         892    13682    +12790     
- Partials         3     1149     +1146     

Flag	Coverage Δ
test	44.81% <67.59%> (-26.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libs/ledger-live-common/src/apps/support.ts	54.54% <ø> (ø)
libs/ledger-live-common/src/env.ts	74.50% <ø> (ø)
...ive-common/src/families/ethereum/hw-signMessage.ts	48.11% <23.94%> (ø)
...ages/hw-app-eth/src/modules/EIP712/EIP712.utils.ts	93.93% <93.47%> (ø)
...js/packages/hw-app-eth/src/modules/EIP712/index.ts	99.42% <98.21%> (ø)
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts	79.04% <100.00%> (ø)
...ledgerjs/packages/hw-app-eth/tests/fixtures/CAL.ts	100.00% <100.00%> (ø)
...s/packages/hw-app-eth/tests/fixtures/dynamicCAL.ts	100.00% <100.00%> (ø)
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts
libs/ledgerjs/packages/hw-app-btc/src/varint.ts
... and 679 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[henri-ly]

LGTM. Just some suggestion but nothing mandatory.
TBH there's a lot of technical stuff I'm not sure about what it does mean tho but it's more la specific to the concept of EIP712

[FabriceDautriat]

@lambertkevin quel est l'intérêt du "show all message" dans le cas EIP191 ?